public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <mgross@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Borislav Petkov <bp@alien8.de>,
	linux-geode@lists.infradead.org,
	platform-driver-x86@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/geode: switch GPIO buttons and LEDs to software properties
Date: Wed, 21 Aug 2024 11:15:45 -0700	[thread overview]
Message-ID: <ZsYu0SEy8ZUKEJqP@google.com> (raw)
In-Reply-To: <a2366dcc-908e-41e9-875e-529610682dc1@redhat.com>

On Wed, Aug 21, 2024 at 12:15:51PM +0200, Hans de Goede wrote:
> Hi Dmitry,
> 
> On 8/21/24 7:25 AM, Dmitry Torokhov wrote:
> > Convert GPIO-connected buttons and LEDs in Geode boards to software
> > nodes/properties, so that support for platform data can be removed from
> > gpio-keys driver (which will rely purely on generic device properties
> > for configuration).
> > 
> > To avoid repeating the same data structures over and over and over
> > factor them out into a new geode-common.c file.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Question has this been tested on at least 1 affected device ?

No unfortunately it has not been as I do not have the hardware. I am
hoping folks on geode list could give this patch a spin.

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-08-21 18:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  5:25 [PATCH] x86/platform/geode: switch GPIO buttons and LEDs to software properties Dmitry Torokhov
2024-08-21 10:15 ` Hans de Goede
2024-08-21 18:15   ` Dmitry Torokhov [this message]
2024-08-22  9:46     ` Hans de Goede
2024-08-22 18:11       ` Dmitry Torokhov
2024-08-30  7:38       ` Linus Walleij
2024-09-04 13:02   ` Hans de Goede
2024-09-04 13:21     ` Borislav Petkov
2024-09-04 16:01       ` Hans de Goede
2024-09-04 18:15         ` Dmitry Torokhov
2024-09-04 18:21           ` Hans de Goede
2024-08-24 11:50 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsYu0SEy8ZUKEJqP@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=bp@alien8.de \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox