Re: [PATCH 1/8] tty: 8250_ingenic: Use devm_clk_get_enabled() helpers

Andy Shevchenko
2024-08-22T13:10:56Z

On Thu, Aug 22, 2024 at 11:39:05AM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().

...

> data->line = serial8250_register_8250_port(&uart);
> if (data->line < 0) {
> err = data->line;
> - goto out_disable_baudclk;
> + return err;
> }

data->line = serial8250_register_8250_port(&uart);
if (data->line < 0)
return data->line;

--
With Best Regards,
Andy Shevchenko