From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4FD1E480 for ; Fri, 23 Aug 2024 00:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724371466; cv=none; b=FXPqy92UOjFJ5CJbpnwhv4j3YZICZolK/crf0o/QsfCK+c1X0+oR1nO55MolQmvtVw/24LqHXxa8pEW72pxAU1GJXJ27C8/QTEKldRvh7HahSa4+fHw57z9zqmCslObuGKZpnt+EPgJk+0JbFsvHrPuX44YICiRrwgcvV0UxKgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724371466; c=relaxed/simple; bh=3QnAdixYo6jA5LfHGge4JAkNB7yoXQF4pxxURUN8JXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tOhPLyCkm0GBQZEYjSg2qU0s1PlVnZt2b0dewlAC9QzQ+4QerDID/lV2fqzwl9RfuhbgN4PLx+oR3b99R2pGrBnYJbU6nnugNsJ85mPaVptjOZ7KvXz1c2vK50G/ia3wDm2Ga2Q18Fx8w9G5WIqVKux1GvzVRkeTbeE+ys9FUjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ON0z/daj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ON0z/daj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724371463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHqbq1AQSOY5EcS479bGVBSadv/yHMIWF28e/YV8WdA=; b=ON0z/dajkrSyPS5QqkOqQfNn8q70Dpr3pIAGQukIfCsgKn9vxlcwBezFraob/MG0BXnKcm reC5GvpSUeJ1N0ZfLqtZyvi9pg1JvVSLyWkM1H3S/zDRvwcoP+XLB5xfDCZ+UlA0Wu7yem qTBCFaKfR0TQhGJOyQUeGj/Ewjo+z1k= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-Q2zfLi0YMr2QKG2BabfBhQ-1; Thu, 22 Aug 2024 20:04:18 -0400 X-MC-Unique: Q2zfLi0YMr2QKG2BabfBhQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0352B1955BF4; Fri, 23 Aug 2024 00:04:14 +0000 (UTC) Received: from localhost (unknown [10.72.112.51]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACCC819560A3; Fri, 23 Aug 2024 00:04:10 +0000 (UTC) Date: Fri, 23 Aug 2024 08:04:06 +0800 From: Baoquan He To: John Paul Adrian Glaubitz Cc: linux-kernel@vger.kernel.org, Dave Vasilevsky , Michael Ellerman , kexec@lists.infradead.org, debian-powerpc@lists.debian.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, akpm@linux-foundation.org, ebiederm@xmission.com, hbathini@linux.ibm.com, piliu@redhat.com, viro@zeniv.linux.org.uk, Sam James Subject: Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items Message-ID: References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-6-bhe@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 08/22/24 at 11:37am, John Paul Adrian Glaubitz wrote: > Hi Baoquan, > > On Thu, 2024-08-22 at 17:17 +0800, Baoquan He wrote: > > > The change to enable CONFIG_CRASH_DUMP by default apparently broke the boot > > > on 32-bit Power Macintosh systems which fail after GRUB with: > > > > > > "Error: You can't boot a kdump kernel from OF!" > > > > > > We may have to turn this off for 32-bit Power Macintosh systems. > > > > > > See this thread on debian-powerpc ML: https://lists.debian.org/debian-powerpc/2024/07/msg00001.html > > > > If so, fix need be made. > > > > We may need change in ARCH_SUPPORTS_CRASH_DUMP of ppc, can you or anyone > > post a patch? I don't know how to identify 32-bit Power Macintosh. > > > > arch/powerpc/Kconfig: > > === > > config ARCH_SUPPORTS_CRASH_DUMP > > def_bool PPC64 || PPC_BOOK3S_32 || PPC_85xx || (44x && !SMP) > > > > config ARCH_SELECTS_CRASH_DUMP > > def_bool y > > depends on CRASH_DUMP > > select RELOCATABLE if PPC64 || 44x || PPC_85xx > > ...... > > config PHYSICAL_START > > hex "Physical address where the kernel is loaded" if PHYSICAL_START_BOOL > > default "0x02000000" if PPC_BOOK3S && CRASH_DUMP && !NONSTATIC_KERNEL > > default "0x00000000" > > I think the architecture does support crash dumps, but I think the kernel has to > be booted from kexec in this case. Booting a kernel with CRASH_DUMP enabled won't > work from Open Firmware. So, I think CRASH_DUMP should just be disabled for > PPC_BOOK3S_32 by default and users who want to use it on these systems, will have to > enable it explicitly. If so, below patch possiblly can fix it. Can you help check if it's OK? >From dd5318dc5dcd66521b31214f0e5921f258532ef8 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Fri, 23 Aug 2024 07:37:38 +0800 Subject: [PATCH] powerpc/crash: do not default to enable CRASH_DUMP for PPC_BOOK3S_32 system Content-type: text/plain Recently it's reported that PowerPC macMini system failed to boot up. It's because CONFIG_CRASH_DUMP=y is set by default on the system since kernel 6.9, and that makes CONFIG_PHYSICAL_START not equaling 0 any more and causes failure of normal kernel bootup. The link of error report can be found here: https://lists.debian.org/debian-powerpc/2024/07/msg00001.html And copy the code snippet here for reference: arch/powerpc/Kconfig: ================== config KERNEL_START hex "Virtual address of kernel base" if KERNEL_START_BOOL default PAGE_OFFSET if PAGE_OFFSET_BOOL default "0xc2000000" if CRASH_DUMP && !NONSTATIC_KERNEL default "0xc0000000" So let's stop enabling CRASH_DUMP by default on PPC_BOOK3S_32. Signed-off-by: Baoquan He --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index d7b09b064a8a..dc5ca58be1d6 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -680,7 +680,7 @@ config RELOCATABLE_TEST relocation code. config ARCH_SUPPORTS_CRASH_DUMP - def_bool PPC64 || PPC_BOOK3S_32 || PPC_85xx || (44x && !SMP) + def_bool PPC64 || PPC_85xx || (44x && !SMP) config ARCH_SELECTS_CRASH_DUMP def_bool y -- 2.41.0