Re: [PATCH] driver core: Fix an uninitialized variable is used by __device_attach()

Zijun Hu
2024-08-23T00:39:06Z

On 2024/8/23 08:14, Greg Kroah-Hartman wrote:
> On Fri, Aug 23, 2024 at 07:46:09AM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> An uninitialized variable @data.have_async may be used as analyzed
>> by the following inline comments:
>>
>> static int __device_attach(struct device *dev, bool allow_async)
>> {
>> // if @allow_async is true.
>>
>> ...
>> struct device_attach_data data = {
>> .dev = dev,
>> .check_async = allow_async,
>> .want_async = false,
>> };
>> // @data.have_async is not initialized.
>
> As Dmitry said, this is incorrect, please fix your broken code analysis
> tool, it is obviously not working properly :(
>

let us slow down firstly to confirm if what Dmitry said is right firstly.

it is not related to any analysis tool, i notice it by reading code.

> thanks,
>
> greg k-h