Re: [PATCH] driver core: Fix an uninitialized variable is used by __device_attach()

Zijun Hu
2024-08-23T11:04:04Z

On 2024/8/23 08:02, Dmitry Torokhov wrote:
> Hi,
>
> On Fri, Aug 23, 2024 at 07:46:09AM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> An uninitialized variable @data.have_async may be used as analyzed
>> by the following inline comments:
>>
>> static int __device_attach(struct device *dev, bool allow_async)
>> {
>> // if @allow_async is true.
>>
>> ...
>> struct device_attach_data data = {
>> .dev = dev,
>> .check_async = allow_async,
>> .want_async = false,
>> };
>> // @data.have_async is not initialized.
>
> No, in the presence of a structure initializer fields not explicitly
> initialized will be set to 0 by the compiler.
>
yes. you are right. compiler will implicitly initialize @data.have_async.

is it worthy to explicitly initialize @data.have_async as existing
@data.want_async as well to prevent misleading human readers since this
initialization approach appears to partial initialization ?

> There is no issue here.
>
> Thanks.
>