From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kunwu Chan <kunwu.chan@linux.dev>
Cc: linux@armlinux.org.uk, krzk@kernel.org, andi.shyti@kernel.org,
robh@kernel.org, gregkh@linuxfoundation.org,
suzuki.poulose@arm.com, rmk+kernel@armlinux.org.uk,
linux-kernel@vger.kernel.org, Kunwu Chan <chentao@kylinos.cn>
Subject: Re: [PATCH] amba: make amba_bustype constant
Date: Fri, 23 Aug 2024 16:48:46 +0300 [thread overview]
Message-ID: <ZsiTPjtnZZIW-K4k@smile.fi.intel.com> (raw)
In-Reply-To: <20240823064203.119284-1-kunwu.chan@linux.dev>
On Fri, Aug 23, 2024 at 02:42:03PM +0800, Kunwu Chan wrote:
> From: Kunwu Chan <chentao@kylinos.cn>
>
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the amba_bustype variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
...
> -extern struct bus_type amba_bustype;
> +extern const struct bus_type amba_bustype;
Can we actually hide this from the outside, i.e. make it static in the C file,
and introduce the dev_is_amba() helper instead?
P.S. You may look at the PNP bus case (some of the latest patches there).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-23 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 6:42 [PATCH] amba: make amba_bustype constant Kunwu Chan
2024-08-23 13:48 ` Andy Shevchenko [this message]
2024-08-26 8:20 ` Kunwu Chan
2024-08-26 10:08 ` Kunwu Chan
2024-08-26 10:40 ` Andy Shevchenko
2024-08-27 7:45 ` Kunwu Chan
2024-08-27 13:37 ` Andy Shevchenko
2024-08-28 2:51 ` Kunwu Chan
2024-08-28 13:17 ` Andy Shevchenko
2024-08-29 1:31 ` Kunwu Chan
2024-09-04 13:58 ` Russell King (Oracle)
2024-09-04 14:07 ` Andy Shevchenko
2024-09-05 8:51 ` Kunwu Chan
2024-08-27 13:46 ` Russell King (Oracle)
2024-08-28 3:00 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsiTPjtnZZIW-K4k@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chentao@kylinos.cn \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=kunwu.chan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox