Re: [PATCH v2 04/10] perf trace: Add some string arguments' name in syscall_arg_fmt__init_array()

Arnaldo Carvalho de Melo
2024-08-22T22:14:09Z

On Thu, Aug 15, 2024 at 09:36:20AM +0800, Howard Chu wrote:
> Add them so that we can augment more strings (which is a file path)
>
> Signed-off-by: Howard Chu <howardchu95@gmail.com>
> ---
> tools/perf/builtin-trace.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7e8c89d9538..84c7398312d8 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1918,7 +1918,13 @@ syscall_arg_fmt__init_array(struct syscall_arg_fmt *arg, struct tep_format_field
>
> if (strcmp(field->type, "const char *") == 0 &&
> ((len >= 4 && strcmp(field->name + len - 4, "name") == 0) ||
> - strstr(field->name, "path") != NULL))
> + strstr(field->name, "path") ||
> + strstr(field->name, "file") ||
> + strstr(field->name, "root") ||
> + strstr(field->name, "key") ||
> + strstr(field->name, "special") ||
> + strstr(field->name, "type") ||
> + strstr(field->name, "description")))
> arg->scnprintf = SCA_FILENAME;
> else if ((field->flags & TEP_FIELD_IS_POINTER) || strstr(field->name, "addr"))
> arg->scnprintf = SCA_PTR;

Humm?

root@number:~# for field_name in file root key special type description ; do grep "field:.* $field_name\>" /sys/kernel/tracing/events/syscalls/sys_enter_*/format ; done

/sys/kernel/tracing/events/syscalls/sys_enter_msgget/format: field:key_t key; offset:16; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_semget/format: field:key_t key; offset:16; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_shmget/format: field:key_t key; offset:16; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_quotactl/format: field:const char * special; offset:24; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_kcmp/format: field:int type; offset:32; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_mount/format: field:char * type; offset:32; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_socket/format: field:int type; offset:24; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_socketpair/format: field:int type; offset:24; size:8; signed:0;
/sys/kernel/tracing/events/syscalls/sys_enter_syslog/format: field:int type; offset:16; size:8; signed:0;
root@number:~#

Skipping this one. Please ellaborate, what am I missing?

- Arnaldo