Re: [PATCH v2 10/10] perf trace: Add general tests for augmented syscalls

Ian Rogers
2024-08-16T03:16:03Z

On Wed, Aug 14, 2024 at 6:37 PM Howard Chu <howardchu95@gmail.com> wrote:
>
> In this test, augmentation for:
>
> * string
> * buffer
> * struct
>
> Is tested.
>
> Please use this command to test it out:
>
> perf test "perf trace general tests"
>
> Signed-off-by: Howard Chu <howardchu95@gmail.com>
> ---
> tools/perf/tests/shell/trace_btf_general.sh | 59 +++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100755 tools/perf/tests/shell/trace_btf_general.sh
>
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> new file mode 100755
> index 000000000000..9c5e9d321b42
> --- /dev/null
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -0,0 +1,59 @@
> +#!/bin/sh
> +# perf trace general tests
> +# SPDX-License-Identifier: GPL-2.0
> +
> +err=0
> +set -e
> +
> +. "$(dirname $0)"/lib/probe.sh
> +skip_if_no_perf_trace || exit 2
> +
> +file1=$(mktemp /tmp/file1_XXXXX)
> +file2=$(echo $file1 | sed 's/file1/file2/g')
> +
> +buffer="this is a buffer for testing"
> +
> +trace_test_string() {
> + echo "Testing perf trace's string augmentation"
> + if ! perf trace -e renameat* --max-events=1 -- mv ${file1} ${file2} 2>&1 | grep -q -E "renameat[2]*.*oldname: \"${file1}\".*newname: \"${file2}\".*"
> + then
> + echo "String augmentation failed"
> + err=1
> + fi
> +}
> +
> +trace_test_buffer() {
> + echo "Testing perf trace's buffer augmentation"
> + if ! perf trace -e write --max-events=1 -- echo "${buffer}" 2>&1 | grep -q -E ".*write.*buf: \"${buffer}.*\".*"
> + then
> + echo "Buffer augmentation failed"
> + err=1
> + fi
> +}
> +
> +trace_test_struct() {
> + echo "Testing perf trace's struct augmentation"
> + if ! perf trace -e clock_nanosleep --max-events=1 -- sleep 1 2>&1 | grep -q -E ".*clock_nanosleep\(rqtp: \{1,\}, rmtp: \{1,\}\).* = 0"
> + then
> + echo "Struct augmentation failed"
> + err=1
> + fi
> +}
> +
> +cleanup() {
> + rm -rf ${file2}
> +}

It can be nice to have a trap handler clean things up, as well as to
say a trap happened (as will happen with any non-zero exit with "set
-e" above). There's an example here where the function of the trap is
printed:
https://lore.kernel.org/lkml/20240813043439.933329-2-irogers@google.com/

Thanks,
Ian

> +
> +trace_test_string
> +
> +if [ $err = 0 ]; then
> + trace_test_buffer
> +fi
> +
> +if [ $err = 0 ]; then
> + trace_test_struct
> +fi
> +
> +cleanup
> +
> +exit $err
> --
> 2.45.2
>