From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors"
Date: Fri, 23 Aug 2024 18:09:54 +0300 [thread overview]
Message-ID: <ZsimQuIJuNNIqn09@smile.fi.intel.com> (raw)
In-Reply-To: <f00bd6e2-19f1-45dd-8899-0f178196079e@sirena.org.uk>
On Tue, Aug 20, 2024 at 06:11:26PM +0100, Mark Brown wrote:
> On Tue, Aug 20, 2024 at 07:44:09PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 20, 2024 at 12:20:30PM +0100, Mark Brown wrote:
>
> > > Please submit patches using subject lines reflecting the style for the
> > > subsystem, this makes it easier for people to identify relevant patches.
> > > Look at what existing commits in the area you're changing are doing and
> > > make sure your subject lines visually resemble what they're doing.
> > > There's no need to resubmit to fix this alone.
>
> > This is a pure and clean revert, not sure if we need to hide that fact.
>
> This is not an issue with the word "revert", it is an issue with the
> formatting of the subject line.
So, should I send a v2?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-08-23 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 19:50 [PATCH v1 1/1] Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors" Andy Shevchenko
2024-08-20 11:20 ` Mark Brown
2024-08-20 16:44 ` Andy Shevchenko
2024-08-20 17:11 ` Mark Brown
2024-08-23 15:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsimQuIJuNNIqn09@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox