From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAB02B9A5 for ; Sun, 25 Aug 2024 06:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724567917; cv=none; b=rt6HOPwBLuP1RQDvYb0WUsnEnbRU+ctHarQSBaBWW53bDwnu2Uh0CsoyiefqBx37w06kUUAbczeo7C8L9OyJ7oeLKWYwKdKOeC35an2n1gqW4uokTshWuzubFfstZ43I8yBXIxoteczB5f/Ru+JrhB06Lz+4SzhDT0U/VjZK2P0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724567917; c=relaxed/simple; bh=L0K0COdIw9y4JHfFG4e6bM1X22MMmS3p4nJ+jNEHcTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=abHQ7BNw6XndECtATvhvxb5pW8uocG4pGjMSR3ATXVWXRuOnkN96/H4C7OWOSs3hBIxATuaDt5EngOX7c2YZ+5h6psiNctMWsES/mb4JkHPNgUeuB/2TLDchq89FqYCjSELZ6TRlzC1tZALTdlNY28a0DxdiBemNdZsGsqlvHWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NjOHj++t; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NjOHj++t" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7c3ebba7fbbso2365821a12.1 for ; Sat, 24 Aug 2024 23:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724567915; x=1725172715; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EnWipGSGRNUpxTH706hRTY90cJiU4b+kfr2jSKM5g/s=; b=NjOHj++tE/p69z1GD3STsdJ69KWlE1u0IW6KcMqJcDHuXkim+T5uEQVPNXtpOzo2x/ 7K7f7EFKe9ZzAkILBqMk1WbVAzCv4MOmbcXFHdbxKlCss3xgwGCMxJ4Pqmzo3Y6CEPCj beKSgjZuRRk7pv8ipx7/Or0PJa3uv6YC2pZL9bqsy6c4y3phm0fJICtC4qGBJCDDF/S+ /NkqPu8Vbl7tYKyps3rD5yitwgpwbFBHxVUoYJM6TPoLX6MSDEe97kSE/7wjMuC5PzGi kf6fDpMnUhybE8NepobdGU0zlxvsMT7sUewCh0qGlbUQiXXYNNj2E9OxEkorTSjAalAo fy3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724567915; x=1725172715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EnWipGSGRNUpxTH706hRTY90cJiU4b+kfr2jSKM5g/s=; b=KA9tGXnivWK68OhzGguhNtUj25nIgjAmtfHeFZ6xKqG9pA9tkIT11XIgZXC+m9de9j ChcjSq36kbT9c6F4XpqIzKjiS5R+7k0Ac0GoIBhBOA7qLFztvEXP9qY2sgNK4mSNN/VF PZYKhTm6pRkDfAlUh2H573u+kzeAEenqSVfhRnLy+ZM84k/ECkELqdHnmsZ+F5F6KP3v Rw+sPsG7HK2S+KujV63TSAnHwdnqWpxaNcJSvII2pkqKXIeqsiv+SOX0K29aBNmkbYVn Ob8ut0OqbnjLVI2Puc7Fm+iuWnzDMfyTndJCCztybDaMuvwnK+OXEKLsP1FLJZl6QgE5 cYqw== X-Forwarded-Encrypted: i=1; AJvYcCUTjDg9P6kxaIm0r2vK+6x/EWtd8PTvYk5qdUpf1GAIOTenwc5vnx7Yd9F59FH6DOQJeSGnebnbhjDDaBk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh5Ol+uzLI/9WGS6Fzy34DkJhHICwYLxg5weRQz0/Bcd4Web3U kQhh0QvSzDniAgdxpgdWSKSSn1ABFLVZdTasPmJl9TGojQU007le X-Google-Smtp-Source: AGHT+IETSpALFu2+A7eFzubBAgBvk/KzvFDhLlTmDgXtMQ3q7/INDCIeOJBXA4FjqYO6SRjgZntLJw== X-Received: by 2002:a05:6a20:c793:b0:1bd:feed:c031 with SMTP id adf61e73a8af0-1cc89d80195mr7497177637.28.1724567914814; Sat, 24 Aug 2024 23:38:34 -0700 (PDT) Received: from five231003 ([2405:201:c006:3236:b871:d8f1:d936:dc0c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2038560e3e8sm49676505ad.219.2024.08.24.23.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 23:38:34 -0700 (PDT) Date: Sun, 25 Aug 2024 12:08:28 +0530 From: Kousik Sanagavarapu To: Nishanth Menon Cc: Jonathan Cameron , Santosh Shilimkar , Nathan Chancellor , Julia Lawall , Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/4] soc: ti: pruss: factor out memories setup Message-ID: References: <20240707055341.3656-1-five231003@gmail.com> <20240707055341.3656-2-five231003@gmail.com> <20240824184950.gzsgdawt2ujjt6ky@subgroup> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240824184950.gzsgdawt2ujjt6ky@subgroup> On Sat, Aug 24, 2024 at 01:49:50PM -0500, Nishanth Menon wrote: > On 10:44-20240707, Kousik Sanagavarapu wrote: > > Factor out memories setup code from probe() into a new function > > pruss_of_setup_memories(). This sets the stage for introducing auto > > cleanup of the device node (done in the subsequent patch), since the > > clean up depends on the scope of the pointer and factoring out > > code into a seperate function obviously limits the scope of the various > typo s/seperate/separate - use --codespell with checkpatch to catch :) > > A follow on patch has the same problem as well. Oh, yes should've used --codespell, my bad. Thanks for spotting. > > variables used in that function. [...] > > - of_node_put(child); > > + ret = pruss_of_setup_memories(dev, pruss); > > + if (ret < 0) > > + goto rpm_put; > > Why? We have not called pm_runtime_enable at this point. Didn't catch this too, will change. Thanks