From: Francesco Dolcini <francesco@dolcini.it>
To: 陈玉凡 <chenyufan@vivo.com>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"opensource.kernel" <opensource.kernel@vivo.com>
Subject: Re: [PATCH v3] wifi: mwifiex: Convert to use jiffies macro
Date: Mon, 26 Aug 2024 08:40:51 +0200 [thread overview]
Message-ID: <Zswjc9GjE9V1C7VT@gaggiata.pivistrello.it> (raw)
In-Reply-To: <c2ae3b1b-d654-47f3-8520-888bdaea873c@vivo.com>
On Mon, Aug 26, 2024 at 03:18:28AM +0000, 陈玉凡 wrote:
> 在 2024/8/24 1:01, Brian Norris 写道:
> > On Fri, Aug 23, 2024 at 03:03:19PM +0800, Chen Yufan wrote:
> >> Use time_after macro instead of using
> >> jiffies directly to handle wraparound.
> >> The modifications made compared to the previous version are as follows:
> >> 1. change the type of mwifiex_auto_tdls_peer::rssi_jiffies to
> >> unsigned long.
> >>
> >> Signed-off-by: Chen Yufan <chenyufan@vivo.com>
> > Changelog questions aside, this looks fine to me:
> >
> > Acked-by: Brian Norris <briannorris@chromium.org>
>
> Thanks, I will pay attention to this question next time.
You should just send a v4 with this addressed and add the acked-by from Brian
while doing it.
Francesco
next prev parent reply other threads:[~2024-08-26 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 7:03 [PATCH v3] wifi: mwifiex: Convert to use jiffies macro Chen Yufan
2024-08-23 7:43 ` Francesco Dolcini
2024-08-23 17:01 ` Brian Norris
2024-08-26 3:18 ` 陈玉凡
2024-08-26 6:40 ` Francesco Dolcini [this message]
2024-09-03 18:31 ` [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zswjc9GjE9V1C7VT@gaggiata.pivistrello.it \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=chenyufan@vivo.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox