From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
sebastian.fricke@collabora.com, linux-doc@vger.kernel.org,
praneeth@ti.com, nm@ti.com, vigneshr@ti.com, s-jain1@ti.com,
r-donadkar@ti.com, b-brnich@ti.com, detheridge@ti.com,
p-mantena@ti.com, vijayp@ti.com, andi.shyti@linux.intel.com,
nicolas@ndufresne.ca, jirislaby@kernel.org, davidgow@google.com,
dlatypov@google.com, corbet@lwn.net, broonie@kernel.org,
jani.nikula@intel.com, rdunlap@infradead.org,
nik.borisov@suse.com, Dave.Martin@arm.com
Subject: Re: [PATCH v2 1/6] math.h: Add macros for rounding to the closest value
Date: Mon, 26 Aug 2024 20:44:19 +0300 [thread overview]
Message-ID: <Zsy-8xXQ01-JhL0m@smile.fi.intel.com> (raw)
In-Reply-To: <20240826150822.4057164-2-devarsht@ti.com>
On Mon, Aug 26, 2024 at 08:38:17PM +0530, Devarsh Thakkar wrote:
> Add below rounding related macros:
>
> round_closest_up(x, y) : Rounds x to the closest multiple of y where y is a
> power of 2, with a preference to round up in case two nearest values are
> possible.
>
> round_closest_down(x, y) : Rounds x to the closest multiple of y where y is
> a power of 2, with a preference to round down in case two nearest values
> are possible.
>
> roundclosest(x, y) : Rounds x to the closest multiple of y, this macro
> should generally be used only when y is not multiple of 2 as otherwise
> round_closest* macros should be used which are much faster.
I understand the point, but if you need to send a v3, please explain
the equivalency between roundclosest() and one (or both?) of the
round_closest_*() in case the argument is power-of-2.
Because from the above I don't see what I'll get in such a case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-26 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:08 [PATCH v2 0/6] Add rounding macros and enable KUnit tests Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 1/6] math.h: Add macros for rounding to the closest value Devarsh Thakkar
2024-08-26 17:44 ` Andy Shevchenko [this message]
2024-08-27 11:27 ` Devarsh Thakkar
2024-08-27 12:40 ` Jani Nikula
2024-08-27 15:14 ` Devarsh Thakkar
2024-08-29 9:19 ` Jani Nikula
2024-08-29 9:54 ` Jiri Slaby
2024-08-30 16:09 ` Devarsh Thakkar
2024-09-30 1:18 ` Randy Dunlap
2024-08-30 13:45 ` Dave Martin
2024-08-26 15:08 ` [PATCH v2 2/6] math.h: Use kernel-doc syntax for division macros Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 3/6] Documentation: core-api: Add math.h macros and functions Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 4/6] lib: Add basic KUnit test for lib/math Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 5/6] lib: math_kunit: Add tests for new macros related to rounding to nearest value Devarsh Thakkar
2024-08-30 14:07 ` Dave Martin
2024-08-26 15:08 ` [PATCH v2 6/6] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zsy-8xXQ01-JhL0m@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Dave.Martin@arm.com \
--cc=andi.shyti@linux.intel.com \
--cc=b-brnich@ti.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=dlatypov@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jani.nikula@intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nik.borisov@suse.com \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=r-donadkar@ti.com \
--cc=rdunlap@infradead.org \
--cc=s-jain1@ti.com \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox