From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Shung-Hsi Yu <shung-hsi.yu@suse.com>,
dwarves@vger.kernel.org, Jiri Olsa <olsajiri@gmail.com>,
masahiroy@kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
linux-kbuild@vger.kernel.org, bpf@vger.kernel.org,
msuchanek@suse.com
Subject: Re: [RFC] kbuild: bpf: Do not run pahole with -j on 32bit userspace
Date: Mon, 26 Aug 2024 14:03:42 -0300 [thread overview]
Message-ID: <Zsy1blxRL9VV9DRg@x1> (raw)
In-Reply-To: <f170d7c2-2056-4f47-8847-af15b9a78b81@kernel.org>
On Mon, Aug 26, 2024 at 10:57:22AM +0200, Jiri Slaby wrote:
> On 22. 08. 24, 17:24, Arnaldo Carvalho de Melo wrote:
> > On Thu, Aug 22, 2024 at 11:55:05AM +0800, Shung-Hsi Yu wrote:
> > I stumbled on this limitation as well when trying to build the kernel on
> > a Libre Computer rk3399-pc board with only 4GiB of RAM, there I just
> > created a swapfile and it managed to proceed, a bit slowly, but worked
> > as well.
>
> Here, it hits the VM space limit (3 G).
right, in my case it was on a 64-bit system, so just not enough memory,
not address space.
> > Please let me know if what is in the 'next' branch of:
> > https://git.kernel.org/pub/scm/devel/pahole/pahole.git
> > Works for you, that will be extra motivation to move it to the master
> > branch and cut 1.28.
> on 64bit (-j1):
> * master: 3.706 GB
> (* master + my changes: 3.559 GB)
> * next: 3.157 GB
> on 32bit:
> * master-j1: 2.445 GB
> * master-j16: 2.608 GB
> * master-j32: 2.811 GB
> * next-j1: 2.256 GB
> * next-j16: 2.401 GB
> * next-j32: 2.613 GB
>
> It's definitely better. So I think it could work now, if the thread count
> was limited to 1 on 32bit. As building with -j10, -j20 randomly fails on
> random machines (32bit processes only of course). Unlike -j1.
Cool, I just merged a patch from Alan Maguire that should help with the
parallel case, would be able to test it? It is in the 'next' branch:
⬢[acme@toolbox pahole]$ git log --oneline -5
f37212d1611673a2 (HEAD -> master) pahole: Teduce memory usage by smarter deleting of CUs
Excerpt of the above:
This leads to deleting ~90 CUs during parallel vmlinux BTF generation
versus deleting just 1 prior to this change.
c7ec9200caa7d485 btf_encoder: Add "distilled_base" BTF feature to split BTF generation
bc4e6a9adfc72758 pahole: Sync with libbpf-1.5
5e3ed3ec2947c69f pahole: Do --lang_exclude CU filtering earlier
c46455bb0379fa38 dwarf_loader: Allow filtering CUs early in loading
⬢[acme@toolbox pahole]$
- Arnaldo
next prev parent reply other threads:[~2024-08-26 17:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 8:59 [RFC] kbuild: bpf: Do not run pahole with -j on 32bit userspace Jiri Slaby (SUSE)
2024-08-20 9:08 ` Jiri Slaby
2024-08-20 14:33 ` Jiri Olsa
2024-08-21 5:32 ` Jiri Slaby
2024-08-21 6:40 ` Jiri Slaby
2024-08-21 7:29 ` Jiri Slaby
2024-08-22 3:55 ` Shung-Hsi Yu
2024-08-22 15:24 ` Arnaldo Carvalho de Melo
2024-08-26 8:57 ` Jiri Slaby
2024-08-26 17:03 ` Arnaldo Carvalho de Melo [this message]
2024-08-26 18:42 ` Sedat Dilek
2024-08-26 18:48 ` Phil Auld
2024-08-26 20:04 ` Arnaldo Carvalho de Melo
2024-08-26 22:07 ` Andrii Nakryiko
2024-08-27 8:37 ` Jiri Slaby
2024-09-04 6:06 ` Jiri Slaby
2024-08-26 20:02 ` Arnaldo Carvalho de Melo
2024-08-26 10:18 ` Sedat Dilek
2024-09-25 8:17 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zsy1blxRL9VV9DRg@x1 \
--to=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jirislaby@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=msuchanek@suse.com \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=olsajiri@gmail.com \
--cc=sdf@fomichev.me \
--cc=shung-hsi.yu@suse.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox