From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D8B1991D0 for ; Mon, 26 Aug 2024 18:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724697007; cv=none; b=BsNRnI2+KDj2Ea8IkJJiC1jznppudJiR+0E7FEIL1nGGfC+k2qmzlDD914GMAD7AP52t+83wfizSgX1US22lvjRT9HXX3Kv48rv+FrecygXMG2QxeJebkL+XB4Z66l0JPscCPs7RJC0s1lCNUDqzHhm3bcDxMowUNs6j+qP4Ng4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724697007; c=relaxed/simple; bh=+04l99NAXXKvs+VMAqdZu3vkpDP0AsPzda+mS2bwvMs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wx5cQfCbp4ZFvTQRxjskGpw+7YxLAMJWKLeE+OpW2DYloNf9PzyoFSSOlzAhzjV/F3xvbyLnrtzUrqkQ+eABa2ti7SW86BWtVUpjxRp2Y+/iPDhn1ib7rMajsc3YSMjr2/t0KDWtbI2em0uP3P/oshOZzyak8JrrkC2eVzdH554= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VEONzkWJ; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VEONzkWJ" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2d5f5d8cc01so3183158a91.0 for ; Mon, 26 Aug 2024 11:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724697004; x=1725301804; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B0uuXq8ne/yMxydWV736DEq+0IEdJmv6uA08FdC9hrU=; b=VEONzkWJiubMOyLILLwtwUO7ovOrTWxWtJExZx2MaIUOVHEkTC16VejZ9QeFMn0Z8Z OyowA40sCZy7tJeqfDiiacTGBN0/TD3wTHoUCwGCS53g3Q1yGsUea4Xod6OW2iPRiXCz pHSk8R2sxiO8tqA/hie3Gf8S68FkbA5NaU2jI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724697004; x=1725301804; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B0uuXq8ne/yMxydWV736DEq+0IEdJmv6uA08FdC9hrU=; b=P/gcaAkYBdkEWB1nPTIivnuMVO3AtuROkF8Tgb6S06XZyy8TOYut2zY/ZiswGtgddS qHq3oY4E4BtJY2zucCOFq9Q/qMoeiuI/nXstsIjiCcy4Y3Lmg7+VyHOb5Bk5X6reNBB2 f4ErK+xLl/YZjqQWSBfCcyWGgnCJ+fRW3BCko3xP2Hgb/2aSuLthE3tgwYjhzKSX6OxR c2s59avoe2pZP6ntURTPtW2fP5OcTCcwP7xoJvRQjyIqVK/hWKA0xkfK4nJNha2NOjkt oZeJS/NdWAbCODPF9JSZi/yiUYT+JWfkJ8hLS9PFwpjmzKjFeErDAzfb+DNQYuHhorC5 deoQ== X-Forwarded-Encrypted: i=1; AJvYcCXzQW6+fO+Hu0klTMAOqfD4EXDUzMOn7MeBJy7NusRe7fjlLFAnV2ZIz9UlWjFmT5w61ZoW/gxQGFyFpd4=@vger.kernel.org X-Gm-Message-State: AOJu0YwL6NYXRrcozN8G4fKyDK/U3QvpT1eIV7Kc8W4WxR7ir4HH41+W zUBxz7hEF0MQ3JM06YATkM6CVwPPZx6WfMgkJi+Kcl9ZCsK0CS7Oq9MMwU2j9A== X-Google-Smtp-Source: AGHT+IGwPAiSI+HmM0qi9NyJaLRHnGBHYsOwZ8N24Jvfmpi8hg6hXb+xyDInVkOXA4sv4ynq6h189w== X-Received: by 2002:a17:90b:1c8e:b0:2cf:f860:f13b with SMTP id 98e67ed59e1d1-2d824ccee69mr757303a91.17.1724697003957; Mon, 26 Aug 2024 11:30:03 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:7e40:430b:848a:1da6]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2d613941e79sm10220036a91.25.2024.08.26.11.30.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 11:30:03 -0700 (PDT) Date: Mon, 26 Aug 2024 11:30:02 -0700 From: Brian Norris To: Jon Lin Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , broonie@kernel.org, heiko@sntech.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, shengfei Xu Subject: Re: [PATCH v3 5/6] spi: rockchip: Suspend and resume the bus during NOIRQ_SYSTEM_SLEEP_PM ops Message-ID: References: <20220216014028.8123-1-jon.lin@rock-chips.com> <20220216014028.8123-6-jon.lin@rock-chips.com> <20220621154218.sau54jeij4bunf56@core> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Jon, You sent HTML email, so it likely didn't reach the mailing list. There are some tips here that might help: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches https://www.infradead.org/~dwmw2/email.html Anyway, I'll quote what I can in response below: On Sat, Aug 24, 2024 at 01:42:14PM +0800, Jon Lin wrote: > I made a submission in the community, and RK's SDK processing plan is > to > make compatibility processing for PM runtime and NOIRQ. I'm not 100% sure what that means, but I see you submitted this: https://lore.kernel.org/all/20240825035422.900370-1-jon.lin@rock-chips.com/ [PATCH] spi: rockchip: Avoid redundant clock disable in pm operation I may give that a proper review later, but I might request you take a look at my patch in addition or instead, which I believe is simpler and clearer, with a better description of what it's solving and why: https://lore.kernel.org/all/20240823214235.1718769-1-briannorris@chromium.org/ [PATCH] spi: rockchip: Resolve unbalanced runtime PM / system PM handling Please let me know if that patch works for you. Brian