Re: [PATCH 08/11] misc: rp1: RaspberryPi RP1 misc driver

kernel test robot
2024-08-21T18:08:54Z

Hi Andrea,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.11-rc4 next-20240821]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Andrea-della-Porta/dt-bindings-clock-Add-RaspberryPi-RP1-clock-bindings/20240821-023901
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/5954e4dccc0e158cf434d2c281ad57120538409b.1724159867.git.andrea.porta%40suse.com
patch subject: [PATCH 08/11] misc: rp1: RaspberryPi RP1 misc driver
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20240822/202408220150.bmFMT5Bk-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408220150.bmFMT5Bk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408220150.bmFMT5Bk-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from include/linux/device.h:15,
from include/linux/pci.h:37,
from drivers/misc/rp1/rp1-pci.c:18:
drivers/misc/rp1/rp1-pci.c: In function 'dump_bar':
>> drivers/misc/rp1/rp1-pci.c:75:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:160:58: note: in expansion of macro 'dev_fmt'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/misc/rp1/rp1-pci.c:74:9: note: in expansion of macro 'dev_info'
74 | dev_info(&pdev->dev,
| ^~~~~~~~
drivers/misc/rp1/rp1-pci.c:75:34: note: format string is defined here
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/misc/rp1/rp1-pci.c:75:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:160:58: note: in expansion of macro 'dev_fmt'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/misc/rp1/rp1-pci.c:74:9: note: in expansion of macro 'dev_info'
74 | dev_info(&pdev->dev,
| ^~~~~~~~
drivers/misc/rp1/rp1-pci.c:75:48: note: format string is defined here
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/misc/rp1/rp1-pci.c:75:18: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'resource_size_t' {aka 'unsigned int'} [-Wformat=]
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:160:58: note: in expansion of macro 'dev_fmt'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/misc/rp1/rp1-pci.c:74:9: note: in expansion of macro 'dev_info'
74 | dev_info(&pdev->dev,
| ^~~~~~~~
drivers/misc/rp1/rp1-pci.c:75:60: note: format string is defined here
75 | "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
| ~~~^
| |
| long long unsigned int
| %x

vim +75 drivers/misc/rp1/rp1-pci.c

> 18 #include <linux/pci.h>
19 #include <linux/platform_device.h>
20 #include <linux/reset.h>
21
22 #include <dt-bindings/misc/rp1.h>
23
24 #define RP1_B0_CHIP_ID 0x10001927
25 #define RP1_C0_CHIP_ID 0x20001927
26
27 #define RP1_PLATFORM_ASIC BIT(1)
28 #define RP1_PLATFORM_FPGA BIT(0)
29
30 #define RP1_DRIVER_NAME "rp1"
31
32 #define RP1_ACTUAL_IRQS RP1_INT_END
33 #define RP1_IRQS RP1_ACTUAL_IRQS
34 #define RP1_HW_IRQ_MASK GENMASK(5, 0)
35
36 #define RP1_SYSCLK_RATE 200000000
37 #define RP1_SYSCLK_FPGA_RATE 60000000
38
39 enum {
40 SYSINFO_CHIP_ID_OFFSET = 0,
41 SYSINFO_PLATFORM_OFFSET = 4,
42 };
43
44 #define REG_SET 0x800
45 #define REG_CLR 0xc00
46
47 /* MSIX CFG registers start at 0x8 */
48 #define MSIX_CFG(x) (0x8 + (4 * (x)))
49
50 #define MSIX_CFG_IACK_EN BIT(3)
51 #define MSIX_CFG_IACK BIT(2)
52 #define MSIX_CFG_TEST BIT(1)
53 #define MSIX_CFG_ENABLE BIT(0)
54
55 #define INTSTATL 0x108
56 #define INTSTATH 0x10c
57
58 extern char __dtbo_rp1_pci_begin[];
59 extern char __dtbo_rp1_pci_end[];
60
61 struct rp1_dev {
62 struct pci_dev *pdev;
63 struct device *dev;
64 struct clk *sys_clk;
65 struct irq_domain *domain;
66 struct irq_data *pcie_irqds[64];
67 void __iomem *bar1;
68 int ovcs_id;
69 bool level_triggered_irq[RP1_ACTUAL_IRQS];
70 };
71
72 static void dump_bar(struct pci_dev *pdev, unsigned int bar)
73 {
74 dev_info(&pdev->dev,
> 75 "bar%d len 0x%llx, start 0x%llx, end 0x%llx, flags, 0x%lx\n",
76 bar,
77 pci_resource_len(pdev, bar),
78 pci_resource_start(pdev, bar),
79 pci_resource_end(pdev, bar),
80 pci_resource_flags(pdev, bar));
81 }
82

--
0-DAY CI Kernel Test Service