From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
<linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
<kernel@quicinc.com>, <quic_pkumpatl@quicinc.com>
Subject: Re: [PATCH v1 2/4] soundwire: stream: Add set_master_channel_map() to set static channel mapping
Date: Mon, 9 Sep 2024 15:50:51 +0100 [thread overview]
Message-ID: <Zt8LS0nyTXggLnkC@opensource.cirrus.com> (raw)
In-Reply-To: <20240909105547.2691015-3-quic_mohs@quicinc.com>
On Mon, Sep 09, 2024 at 04:25:45PM +0530, Mohammad Rafi Shaik wrote:
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index 5e0dd47a0412..264450763bab 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -857,6 +857,8 @@ struct sdw_master_ops {
> (struct sdw_bus *bus);
> int (*set_bus_conf)(struct sdw_bus *bus,
> struct sdw_bus_params *params);
> + int (*set_master_channel_map)(struct sdw_bus *bus, int *ch_mask,
> + unsigned int port_num);
At the very least this needs some kernel doc to explain what the
new callback is for, I think also the commit message could use
some work to help us understand the purpose here.
Thanks,
Charles
next prev parent reply other threads:[~2024-09-09 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 10:55 [PATCH v1 0/4] Add static channel mapping between soundwire master and slave Mohammad Rafi Shaik
2024-09-09 10:55 ` [PATCH v1 1/4] ASoC: dt-bindings: wcd938x-sdw: Add static channel mapping support Mohammad Rafi Shaik
2024-09-10 7:45 ` Krzysztof Kozlowski
2024-09-11 11:33 ` Dmitry Baryshkov
2024-09-09 10:55 ` [PATCH v1 2/4] soundwire: stream: Add set_master_channel_map() to set static channel mapping Mohammad Rafi Shaik
2024-09-09 14:50 ` Charles Keepax [this message]
2024-09-09 10:55 ` [PATCH v1 3/4] soundwire: qcom: Add static channel mapping support in soundwire master Mohammad Rafi Shaik
2024-09-09 10:55 ` [PATCH v1 4/4] ASoC: codecs: wcd937x: Add static channel mapping support in wcd937x-sdw Mohammad Rafi Shaik
2024-09-09 14:49 ` [PATCH v1 0/4] Add static channel mapping between soundwire master and slave Charles Keepax
2024-09-09 15:10 ` Mark Brown
2024-09-09 16:03 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt8LS0nyTXggLnkC@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_mohs@quicinc.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox