From: Petr Mladek <pmladek@suse.com>
To: Yu Liao <liaoyu15@huawei.com>
Cc: tony.lindgren@linux.intel.com, liwei391@huawei.com,
rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] printk: Export match_devname_and_update_preferred_console()
Date: Mon, 9 Sep 2024 18:06:53 +0200 [thread overview]
Message-ID: <Zt8dHUN3Z78fmYFd@pathway.suse.cz> (raw)
In-Reply-To: <20240909075652.747370-1-liaoyu15@huawei.com>
On Mon 2024-09-09 15:56:52, Yu Liao wrote:
> When building serial_base as a module, modpost fails with the following
> error message:
>
> ERROR: modpost: "match_devname_and_update_preferred_console"
> [drivers/tty/serial/serial_base.ko] undefined!
>
> Export the symbol to allow using it from modules.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409071312.qlwtTOS1-lkp@intel.com/
> Fixes: 12c91cec3155 ("serial: core: Add serial_base_match_and_update_preferred_console()")
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
It looks good. I have pushed the fix into printk/linux.git,
branch for-6.11-fixup. I am going to send a pull request
later this week.
Best Regards,
Petr
next prev parent reply other threads:[~2024-09-09 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 7:56 [PATCH -next] printk: Export match_devname_and_update_preferred_console() Yu Liao
2024-09-09 8:25 ` Tony Lindgren
2024-09-09 10:56 ` Tony Lindgren
2024-09-10 6:41 ` Petr Mladek
2024-09-10 7:10 ` Tony Lindgren
2024-09-09 16:06 ` Petr Mladek [this message]
2024-09-09 17:27 ` [tip: sched/rt] " tip-bot2 for Yu Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt8dHUN3Z78fmYFd@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=liaoyu15@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.lindgren@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox