From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4588A15B543 for ; Thu, 29 Aug 2024 07:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724915232; cv=none; b=fyXvz5he0Vwy3YOVrvxzkCZx8S1Kf0C4cZm7C+6j+gXuvdVCDZqoWdLk/h1w9+ftmxyEbM8UecV6EWM8nSs1UgMiDsehwulsf4Tv6GEzydCaVUIac3IXCfxMhKjzagbmF3TdemsJKjt2Ci42ubnVdcfew5RVvo7sAPWcFEceRXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724915232; c=relaxed/simple; bh=iIrdz8xHWQOEmDFHwlLnKLxhlF+qVRPko7F/x7pE884=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HaAS0vXZPjfD++zfJ5QvDvLphbH9YbLe0go3ypZDcoiRgWeqIuVW7kLN+iNNMBPtjsqForNjvZvgiSUskYDoRraPsWCq6QfTNfkGeI8tq4RZMJ+IvyAp/MA/7eueANspsTLa1ePH5qN3oSK+gqLS84ihTfLJsRleRh+wHoFvUsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C78EhkWZ; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C78EhkWZ" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5bed72ff443so273447a12.1 for ; Thu, 29 Aug 2024 00:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724915228; x=1725520028; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EDV7LYU2DJnsK4TmWVUaf/+yENKrN1KF0jvLEaGLdFU=; b=C78EhkWZlwdNl1s6yFdlE52bVdMr+V8Jflg7LLxWQ9+zV5DmAPxCcqt4Ar2E/rbLHm xtE5Bi60AJgqYRUj2e037uhCuUjvfoADqb9IcaSJ5no2w9XY1/x3ZNX1E4Nd4cpBnT9B yJ1w9q5y/xg2pmlaNYRE3dmt0tIF9tFzs4RZleE21fkIwG7VRFA6H7xESiABacL36O09 jFfXvpPxmX8WRrWdY48OlqvRj8j42JOmwB0+4sGVGhvhoHzhjbHctnovhbZGPocDoiNY GcrEWvz2wC6Zn59xDtjBzbYpKKdfwUJk5fu3wAS0hVVxbwpPeiBEQuchd+0qXXLcgLmC pgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724915228; x=1725520028; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EDV7LYU2DJnsK4TmWVUaf/+yENKrN1KF0jvLEaGLdFU=; b=ArhTMLtnfVJKWHNr9lKpRUY9+rQaVmBwJWImruPyleygFvN19n5vEYC6DPvvt7dNi6 bP4dqC6Gfx1HWQSg/yISl5yCUIx2qgEwPzuuXQtMLfJR16XPr+wHF4MyoM8PjAhe0l1N DsVrXcXuMokTreibgzesYz6ayjbRsDNnW79vM0gh5bUzksvHmay+SVv8i9HBCIKzASvz Qg16UkmfRa0wJa/p1wgOeuhcdTThqiKcd9hfXzns9Bw+oPsQc6f1xqIgdaUtcpmDcBw0 p3/NZpXWZzjSaWV6wUiVRWwhsznOT4h9BJrl2VeVf5mU1l88MnDKiP4073SWE/q9eg0H 7+4A== X-Forwarded-Encrypted: i=1; AJvYcCV+YJMSdt/vfqaKvlBMxRuRFT5nBkSsHuFQyalmNV/t3FslwYHAxPYFbLAtC9JBOILzMI398VlWkZYCMPk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6up6mI1njLMJsLHET0CWp+yoZOIEdnKBq3d1O7lzqArQvlNKD Do3+5qLE8T3b7NjPUwudtEk4EdlsqgavPSRi2diWxXocn3mv68y2eDXM8GWpOLk= X-Google-Smtp-Source: AGHT+IFNrbFztgjXMHcLbgg0oT3MbRl4ZmtEJeLPKhMXUsVFcQa9Y3/vmFxcGOFsZGHW/LlDarOk/g== X-Received: by 2002:a17:907:e92:b0:a80:7193:bd88 with SMTP id a640c23a62f3a-a897f8f78a4mr131638966b.36.1724915228420; Thu, 29 Aug 2024 00:07:08 -0700 (PDT) Received: from linaro.org ([82.79.186.176]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8988feae63sm38563966b.35.2024.08.29.00.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 00:07:07 -0700 (PDT) Date: Thu, 29 Aug 2024 10:07:05 +0300 From: Abel Vesa To: Pengfei Li Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Message-ID: References: <20240627082426.394937-1-pengfei.li_1@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627082426.394937-1-pengfei.li_1@nxp.com> On 24-06-27 16:24:24, Pengfei Li wrote: > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h to > indicate the number of clocks, but it is not part of the ABI, so > it should be moved to clk driver. > Right, why? All other providers have been using the _CLK_END from the bindings header. What is so special about this ? AFAICT, nothing. > --- > Change for v2: > - Use pre-processor define to simplify code. > - link to v1: https://lore.kernel.org/all/20240625175147.94985-1-pengfei.li_1@nxp.com/ > > Pengfei Li (2): > clk: imx93: Move IMX93_CLK_END macro to clk driver > dt-bindings: clock: imx93: Drop IMX93_CLK_END macro definition > > drivers/clk/imx/clk-imx93.c | 2 ++ > include/dt-bindings/clock/imx93-clock.h | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > -- > 2.34.1 >