Re: [PATCH v1 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag

Krzysztof Kozlowski
2024-09-05T06:21:39Z

On 05/09/2024 07:43, Mukesh Kumar Savaliya wrote:
>
>
> On 9/4/2024 11:50 PM, Krzysztof Kozlowski wrote:
>> On 04/09/2024 20:12, Mukesh Kumar Savaliya wrote:
>>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>>>> people, so fix your workflow. Tools might also fail if you work on some
>>>> ancient tree (don't, instead use mainline) or work on fork of kernel
>>>> (don't, instead use mainline). Just use b4 and everything should be
>>>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>>>> patches to the patchset.
>>>>
>>>> You missed at least devicetree list (maybe more), so this won't be
>>>> tested by automated tooling. Performing review on untested code might be
>>>> a waste of time.
>>>>
>>>
>>> You mean flag addition into DTSI file ? If yes, then the intention was
>>> to just enable feature support but not into mainline because it should
>>> happen per board or usecase. Please suggest if i can enable particular
>>> node with DTSI feature flag.
>>> Please correct me if my understanding on your ask went wrong.
>>
>> How is this related?
> "You missed at least devicetree list (maybe more)" - Do you mean to say
> i missed to add DTSI changes OR maintainers for DTSI ? seeking clarity
> to avoid confusion.

You did not CC maintainers and necessary list. I wrote nothing about
DTSI. You are expected to use tools, not manually come with some address
list.

Best regards,
Krzysztof