Re: [PATCH v1 0/4] Enable shared SE support over I2C

Bryan O'Donoghue
2024-08-29T09:56:27Z

On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote:
> This Series adds support to share QUP based I2C SE between subsystems.
> Each subsystem should have its own GPII which interacts between SE and
> GSI DMA HW engine.

What is SE ?

GPII - general purpose interrupt ... ?

You have too many acronyms here, which makes reading and understanding
your cover letter a bit hard.

Please define at least the term SE in your cover letter and in your patch.

In the patch you use the term TRE which without diving into the code I
vaguely remember is a register..

- GPII
- GSI
- SE
- TRE

Need to be defined to make what's going on in this series more "grokable".

A cover letter should assume a reviewer is familiar with the basics of a
system - no need to define what I2C is but, similarly shouldn't assume a
reviewer is numerate in the taxonomy of vendor specific architecture
e.g. whats SE ?

---
bod