Re: [PATCH v2 1/2] usb: typec: ucsi: Enable ASUS zenbook quirk for VivoBooks

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Hi, Christian,

Sorry, I did not look at this properly in v1.

On Thu, Aug 29, 2024 at 12:01:08PM +0200, Christian A. Ehrhardt wrote:
> The quirk for some ASUS zenbook models is required for
> ASUS VivoBooks. Apply the quirk to these as well.
> 
> This is part of the fix for the builtin keyboard on ASUS
> VivoBooks.

I think that explanation goes to patch 2/2 and vise versa.

> Reported-by: Anurag Bijea <icaliberdev@gmail.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219108
> Bisected-by: Christian Heusel <christian@heusel.eu>
> Fixes: de52aca4d9d5 ("usb: typec: ucsi: Never send a lone connector change ack")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> ---
>  drivers/usb/typec/ucsi/ucsi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 4039851551c1..540cb1d2822c 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -38,6 +38,10 @@
>  
>  void ucsi_notify_common(struct ucsi *ucsi, u32 cci)
>  {
> +	/* Ignore bogus data in CCI if busy indicator is set. */
> +	if (cci & UCSI_CCI_BUSY)
> +		return;

This does not look correct. Doesn't this mean you'll timeout always if
BUSY is set?

Couldn't you just check the BUSY as the first action, and then clear
the other bits in CCI if it is set, if that is the problem?

Btw. Does 4f322657ade1 ("usb: typec: ucsi: Call CANCEL from single
location") affect the situation in any way?

thanks,

-- 
heikki