From: Keith Busch <kbusch@kernel.org>
To: Puranjay Mohan <pjy@amazon.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
puranjay@kernel.org, amazon-linux-kernel@amazon.com
Subject: Re: [PATCH v3] nvme: fix metadata handling in nvme-passthrough
Date: Fri, 30 Aug 2024 08:52:09 -0600 [thread overview]
Message-ID: <ZtHcmYvTTmZfTEXY@kbusch-mbp> (raw)
In-Reply-To: <20240829133217.1627-1-pjy@amazon.com>
On Thu, Aug 29, 2024 at 01:32:17PM +0000, Puranjay Mohan wrote:
> On an NVMe namespace that does not support metadata, it is possible to
> send an IO command with metadata through io-passthru. This allows issues
> like [1] to trigger in the completion code path.
> nvme_map_user_request() doesn't check if the namespace supports metadata
> before sending it forward. It also allows admin commands with metadata to
> be processed as it ignores metadata when bdev == NULL and may report
> success.
>
> Reject an IO command with metadata when the NVMe namespace doesn't
> support it and reject an admin command if it has metadata.
>
> [1] https://lore.kernel.org/all/mb61pcylvnym8.fsf@amazon.com/
Thanks, applied to nvme-6.12.
prev parent reply other threads:[~2024-08-30 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 13:32 [PATCH v3] nvme: fix metadata handling in nvme-passthrough Puranjay Mohan
2024-08-30 14:52 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtHcmYvTTmZfTEXY@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=amazon-linux-kernel@amazon.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pjy@amazon.com \
--cc=puranjay@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox