* [PATCH] android: binder: modify incorrect comments
@ 2024-08-30 7:37 bajing
2024-08-31 14:16 ` Carlos Llamas
0 siblings, 1 reply; 2+ messages in thread
From: bajing @ 2024-08-30 7:37 UTC (permalink / raw)
To: gregkh
Cc: arve, tkjos, maco, joel, brauner, cmllamas, surenb, linux-kernel,
bajing
The comment for binder_proc_unlock was incorrect, so it should be modified.
Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index fc55b5d0e4f3..578861d57045 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
}
/**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
* @proc: struct binder_proc to acquire
*
* Release lock acquired via binder_proc_lock()
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] android: binder: modify incorrect comments
2024-08-30 7:37 [PATCH] android: binder: modify incorrect comments bajing
@ 2024-08-31 14:16 ` Carlos Llamas
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Llamas @ 2024-08-31 14:16 UTC (permalink / raw)
To: bajing; +Cc: gregkh, arve, tkjos, maco, joel, brauner, surenb, linux-kernel
On Fri, Aug 30, 2024 at 03:37:43PM +0800, bajing wrote:
> The comment for binder_proc_unlock was incorrect, so it should be modified.
Can you specify why the comment is incorrect?
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
> ---
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fc55b5d0e4f3..578861d57045 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
> }
>
> /**
> - * binder_proc_unlock() - Release spinlock for given binder_proc
> + * binder_proc_unlock() - Release outer lock for given binder_proc
> * @proc: struct binder_proc to acquire
> *
> * Release lock acquired via binder_proc_lock()
> --
> 2.33.0
>
I'm ok with your change. It is specific about which spinlock it releases
(even though this is obvious from the code). It also pairs better with
the acquire comment block in binder_proc_lock().
However, you need to modify your commit message as the current comment
is technically _not_ incorrect. Can you please send a v2?
Thanks,
--
Carlos Llamas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-31 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 7:37 [PATCH] android: binder: modify incorrect comments bajing
2024-08-31 14:16 ` Carlos Llamas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox