Re: [PATCH 08/11] misc: rp1: RaspberryPi RP1 misc driver

Greg Kroah-Hartman
2024-08-24T05:17:30Z

On Tue, Aug 20, 2024 at 04:36:10PM +0200, Andrea della Porta wrote:
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2610,6 +2610,9 @@
> #define PCI_VENDOR_ID_TEKRAM 0x1de1
> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29
>
> +#define PCI_VENDOR_ID_RPI 0x1de4
> +#define PCI_DEVICE_ID_RP1_C0 0x0001

Minor thing, but please read the top of this file. As you aren't using
these values anywhere outside of this one driver, there's no need to add
these values to pci_ids.h. Just keep them local to the .c file itself.

thanks,

greg k-h