From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 653F8155398 for ; Mon, 2 Sep 2024 06:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725259246; cv=none; b=Qxq5iHp0zZV86dkrwdJd6/T1ztDjuGPqa+GoAvLdKwfO7v24yiYI8rbiXo4F9ITvppS/MtNdJoD5j3T+OnAoK0l3aMLWBBkOcMNxd2j8YLVwzcdAHqNY4DPt0MrXVZZu7E3wkfQ8FHxZcGUdVGW5Von648LS8a4d86+wPtxn48g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725259246; c=relaxed/simple; bh=Kg0dKyORwMyYc2KUGG2ucR8CXCobYKSxhwUUOFnx2xE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iwZTwPJd0J/OiGe6rVqe3S1+NPxcHCA0mA/uMm0hE4U4/pICU3vTmOWGKjavIIlv9uXFz7Nsa5kTgw34xlbMYJ+Huq8JeiJF1xh9fkkznPW+TkuVZnmFgv2Nvs33UI1fSDHWWn8KjiBW95r8msqDRDnxfPlu6FvchGmDgQKOfak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sl0jo-0008Kh-EN; Mon, 02 Sep 2024 08:40:32 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sl0jn-004q7G-G4; Mon, 02 Sep 2024 08:40:31 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sl0jn-002TPc-1G; Mon, 02 Sep 2024 08:40:31 +0200 Date: Mon, 2 Sep 2024 08:40:31 +0200 From: Sascha Hauer To: David Lin Cc: Francesco Dolcini , Calvin Owens , Brian Norris , Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x Message-ID: References: <20240826072648.167004-1-s.hauer@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mon, Sep 02, 2024 at 02:24:53AM +0000, David Lin wrote: > > From: Sascha Hauer > > Sent: Monday, August 26, 2024 3:27 PM > > To: Francesco Dolcini > > Cc: Calvin Owens ; Brian Norris > > ; Kalle Valo ; David Lin > > ; linux-wireless@vger.kernel.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sascha Hauer > > > > Subject: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x > > > > Caution: This is an external email. Please take care when clicking links or > > opening attachments. When in doubt, report the message using the 'Report > > this email' button > > > > > > This series adds support for the iw61x chips to the mwifiex driver. > > There are a few things to address, hence the RFC status. See the commit > > messages for details. The series is based on wireless-next/main. > > > > I am sending this now since people requested it here [1], but as it's out now > > feel free to leave your comments to the issues mentioned (or others I haven't > > mentioned ;) > > > > [1] > > https://lore.kern/ > > el.org%2Fall%2F20240809094533.1660-1-yu-hao.lin%40nxp.com%2F&data=05 > > %7C02%7Cyu-hao.lin%40nxp.com%7C184ab4fed58647150f8508dcc5a0789a%7 > > C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638602540229716119% > > 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB > > TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cACBHxaQvcOqu6ri > > BoAlZDONRlGQ4j5DcglEV9T%2BpYU%3D&reserved=0 > > > > Sascha > > > > > > Sascha Hauer (4): > > wifi: mwifiex: release firmware at remove time > > wifi: mwifiex: handle VDLL > > wifi: mwifiex: wait longer for SDIO card status > > mwifiex: add iw61x support > > > > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 +++++++++++++++++++ > > drivers/net/wireless/marvell/mwifiex/fw.h | 16 ++++ > > drivers/net/wireless/marvell/mwifiex/main.c | 9 +- > > drivers/net/wireless/marvell/mwifiex/main.h | 4 + > > drivers/net/wireless/marvell/mwifiex/sdio.c | 81 ++++++++++++++++- > > drivers/net/wireless/marvell/mwifiex/sdio.h | 3 + > > .../net/wireless/marvell/mwifiex/sta_event.c | 4 > > + .../net/wireless/marvell/mwifiex/uap_event.c | 4 + > > include/linux/mmc/sdio_ids.h | 3 + > > 9 files changed, 205 insertions(+), 5 deletions(-) > > > > -- > > 2.39.2 > > I think you ported VDLL related code from nxpwifi and you also traced > our private/downstream MXM driver. I ported it from this repository: https://github.com/nxp-imx/mwifiex-iw612.git Is that the one you are referring to as MXM driver? > If this is the case, I think you should know nxpwifi already cleaned > up the porting VDLL code from MXM driver. > I check your patch quickly. You ported the new SDIO data type > (MWIFIEX_TYPE_VDLL) from nxpwifi, but you > did not port the code to support this new data type from nxpwifi. In > other word, you did not test your > patch before submission (same as some of your patches). I did test it. It works with the iw61x as well as older chips. There are likely details I haven't tested, but it generally works. If there are details I should test additionally please let me know. > > Another thing is that this new SDIO data type should be handled > carefully with other existed SDIO data type. > > Nxpwifi only supports new SDIO mode, so the modification to support > NXPWIFI_TYPE_VDLL can be clean and simple. If you want to port the > code to Mwifiex, there is no one-to-one modification of the code. > > Another important thing is that you should consider if your > modifications will affect existed devices or not. > You need to check if you should check firmware version or chip type > before adding some code. The VDLL code I added for the iw61x only reacts to the EVENT_VDLL_IND event. So as long as a firmware doesn't send such an event nothing is changed with this patch, and I haven't seen an older chip sending a VDLL event. > > BTW, no matter if you add the code with or without checking of > firmware version or chip type, you should test > your modifications for IW61x and at least one legacy device if the > code is added to Mwifiex. I did. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |