Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

Jason A. Donenfeld
2024-09-02T01:20:36Z

On Sun, Sep 01, 2024 at 08:43:10PM +0200, Christophe Leroy wrote:
> >> How would this fit in the logic where IIUC you just remove '_64' from
> >> 'x86_64' to get 'x86'
> >
> > Huh? That's not what tools/scripts/Makefile.arch does.
>
> Hum ... yes sorry I looked at it too quickly and mixed things up with
> the other patch.
>
> Nevertheless, if I understand well what tools/scripts/Makefile.arch does
> on an x86_64 for instance:
>
> uname -m returns x86_64
> HOSTARCH = x86 (sed -e s/x86_64/x86)
> ARCH = x86
> SRCARCH = x86
>
> If you build with make ARCH=x86_64,
> SRCARCH = x86
>
> So I still can't see how you can use that to know if it is a x86_64 or not.

By the use of CONFIG_X86_32, which is also used elsewhere in that
samme makefile for something else (so I assume it's wired up in the
context where it counts, and if not, that's a bug that affects both
spots and should be fixed)..