Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

Mark Brown
2024-09-02T12:37:21Z

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Mon, Sep 02, 2024 at 02:22:38PM +0200, Christophe Leroy wrote:

> When vdso_test_getcpu doesn't find the vDSO entry point, it prints an error
> text and returns KSFT_SKIP

> I thought it would be more correct to have the same behaviour on
> vdso_test_getrandom instead of trying to build it only when the underlying
> kernel supports it.

The problem is that the test incorporates assembler code so it simply
won't build for architectures without explicit porting, the issue isn't
if the target kernel supports it but rather that the test won't compile
in the first place.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]