From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A4219F139; Mon, 2 Sep 2024 14:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725286792; cv=none; b=f8P3PywGiQ44Kx3muRqUFjwN4c1sgbxGNa59MDJ2atpCH+WRkGxN2g+Fq3o0hRbY7jP2vel+DunotSp1IVTgp41C0HiAGs6aJzlyGG8n+iW0EIypAqpbPfaBCW7yLMAFgPCV0TNqo9T20hivtQXZDnfLGOwz59jpJ38wY3dpf30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725286792; c=relaxed/simple; bh=k61ZjOC1ybeCJrLZm4+RQOKp9zNpJr6PNFSFYlIpUZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jKvZYrqvwxcFbsKuVTYibR7WK3DHzxNhJVUV9PUnoUWyX5zdumaXT8ZpuDmDAy4zQwnPV+tcFXiY3SpGgECSQB1yl8SpMzY3MgvTzR6++ZUkedj6jQ/wuPDAaqmaFCpTkcwJavK1pKrSl+hcwb5XLEsnH1nysqXrIlg3c3d8m60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b=KeV5OogA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="KeV5OogA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9739EC4CEC2; Mon, 2 Sep 2024 14:19:49 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="KeV5OogA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725286788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IdelkNQNEJ/x7d6HdhvWfHMFNgEcvt0QuA/u9U3RtjY=; b=KeV5OogAbTBAMOtuoki3DgeJqyVvllDRgndH2dkze3yJLmaacKcbExWRMITKy5or0SV258 x4gQsu2kUb+oZQiOAJEgQaamdG25Rb8FTyy7E8qPs0Lh1OU6kkbcfMQTYpVqXGsBV9qP8K jOeTQOwZFwE9yTVHoh1o8Hd59SW8oSE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5527ce07 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Sep 2024 14:19:47 +0000 (UTC) Date: Mon, 2 Sep 2024 16:19:42 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Message-ID: References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Sep 02, 2024 at 04:16:48PM +0200, Christophe Leroy wrote: > Can do that, but there will still be a problem with chacha selftests if > I don't opt-out the entire function content when it is ppc64. It will > build properly but if someone runs it on a ppc64 it will likely crash > because only the low 32 bits of registers will be saved. What if you don't wire up the selftests _at all_ until the ppc64 commit? Then there'll be no risk. (And I think I would prefer to see the 32-bit code all in the 32-bit commit; that'd make it more straight forward to review too.)