From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2DB1DAC5F for ; Tue, 3 Sep 2024 07:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725348586; cv=none; b=FtqbmeYKXP0SvujaiLipmxxC+OKBMkhFQeiAhqAJQfJYc8i9cVRAewAGRLe5eKNiH111Iuc45ez9hpX3EgJVxAdinHUjyEc/ldQPjz/eQ/xgOv5aeOBHk/eIDgWmH6+sb7bZP2Gsj2006NU9f31uPdS55SFxqdu7J5kiiG9+QPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725348586; c=relaxed/simple; bh=RhoUQ7A0/YWMznDNlR/sD3pn+cKlBvmXNBktAEQZ/TY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mNHVFxMVbp18HTSUs7v920nO2rnwCw1C7btCtAe+YyUNfywqLkWec+aKh4OwYzPH/v4BKD9xf1+peiNa86dpByfvCmq2P/WFthNbZDvEKIPk4aeg1pTHB/Exy5TFvXjeJiyXijFh+Rae+OIq0a9o9BjAmCXpbz6q4tSavnrMUys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slNyq-0006Fv-2x; Tue, 03 Sep 2024 09:29:36 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slNyp-00581t-3h; Tue, 03 Sep 2024 09:29:35 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1slNyo-004MyL-3D; Tue, 03 Sep 2024 09:29:35 +0200 Date: Tue, 3 Sep 2024 09:29:34 +0200 From: Sascha Hauer To: David Lin Cc: Francesco Dolcini , Calvin Owens , Brian Norris , Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x Message-ID: References: <20240826072648.167004-1-s.hauer@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote: > > > > > Not only this code segment. In fact, you did not add VDLL data > > > > > patch support > > > > to sdio.c. > > > > > If you try to add the code and do test, you will know what is > > > > > missing in your > > > > code. > > > > > > > > Could you point me to the code you mean? > > > > > > > > Sascha > > > > > > > > > > I only know the porting VDLL code in nxpwifi. > > > > Yes, and I asked for a pointer to that code, some function name, or file/line or > > whatever, because I looked at the nxpwifi driver and don't know what you > > mean with "VDLL data patch support" in sdio.c. > > > > Sascha > > > > It is better for you to check MXM driver. It is the same as Mwifiex which support all SDIO modes. Now I am confused. You said: > In fact, you did not add VDLL data patch support to sdio.c I was under the assumption that the nxpwifi driver that you specifically posted for the iw61x chipset should contain this code. Isn't that the case? BTW did you really mean "VDLL data patch" or did you mean "VDLL data path"? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |