From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4141CF28D for ; Tue, 3 Sep 2024 06:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725345200; cv=none; b=pVpC7ZS1/FUDd4/863CzPYqskGHVb3dw/Au6EdukNzvqCFTfpwkKySdJSEGquYSpKOuyY4BSToTXxahrORzTRXBK/YaHy/Xpq3hyPAgrn8fiG4kj+CJ2CDhgO7S6nIxWjCgtO1TxUJZe5RllgkyyIs4afVlSGPMo8PkwjJbbkjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725345200; c=relaxed/simple; bh=bWTYGSEkN+qEPafiZXabnURnos5QBjb8WnYA9NzgsqY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LhYI0D/E/Feq9/2K145nJWILk3w2oCc4XynXr/XeRtUC/TiBnfiJc5AdH8MDcS4fW7bnEhjw8GdG5tex2+6Z0HEjcS0gHdqfHeLXW/KTRgZky99yKDcgdoyDH3BrWhyrnJ2VYMcRKYTcwktjcwMSicUYFcEQyBZAxuv2oYLkXpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slN65-0002jB-HH; Tue, 03 Sep 2024 08:33:01 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slN64-0057Lz-5G; Tue, 03 Sep 2024 08:33:00 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1slN64-004Lui-08; Tue, 03 Sep 2024 08:33:00 +0200 Date: Tue, 3 Sep 2024 08:33:00 +0200 From: Sascha Hauer To: David Lin Cc: Francesco Dolcini , Calvin Owens , Brian Norris , Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x Message-ID: References: <20240826072648.167004-1-s.hauer@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Tue, Sep 03, 2024 at 01:51:46AM +0000, David Lin wrote: > > From: Sascha Hauer > > Sent: Monday, September 2, 2024 9:11 PM > > To: David Lin > > Cc: Francesco Dolcini ; Calvin Owens > > ; Brian Norris ; Kalle Valo > > ; linux-wireless@vger.kernel.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x > > > > > > > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > > > > > > > > > Sascha Hauer (4): > > > > > > > > wifi: mwifiex: release firmware at remove time > > > > > > > > wifi: mwifiex: handle VDLL > > > > > > > > wifi: mwifiex: wait longer for SDIO card status > > > > > > > > mwifiex: add iw61x support > > > > > > > > > > > > > > > > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 > > > > > > +++++++++++++++++++ > > > > > > > > drivers/net/wireless/marvell/mwifiex/fw.h | 16 ++++ > > > > > > > > drivers/net/wireless/marvell/mwifiex/main.c | 9 +- > > > > > > > > drivers/net/wireless/marvell/mwifiex/main.h | 4 + > > > > > > > > drivers/net/wireless/marvell/mwifiex/sdio.c | 81 > > > > ++++++++++++++++- > > > > > > > > drivers/net/wireless/marvell/mwifiex/sdio.h | 3 + > > > > > > > > .../net/wireless/marvell/mwifiex/sta_event.c | 4 > > > > > > > > + .../net/wireless/marvell/mwifiex/uap_event.c | 4 + > > > > > > > > include/linux/mmc/sdio_ids.h | 3 + > > > > > > > > 9 files changed, 205 insertions(+), 5 deletions(-) > > > > > > > > > > > > > > > > -- > > > > The VDLL support in the downstream driver supports a case when a > > > > VDLL event comes in while a command is being sent. I catched this > > > > with this > > > > test: > > > > > > > > if (adapter->cmd_sent) { > > > > mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n", > > > > __func__); > > > > return -EBUSY; > > > > } > > > > > > > > The downstream driver defers handling of the VDLL event to the main > > > > process in this case. I haven't implemented this case in my patch > > > > because I wasn't able to trigger it, but is this the case you are referring to? > > > > > > > > > > Not only this code segment. In fact, you did not add VDLL data patch support > > to sdio.c. > > > If you try to add the code and do test, you will know what is missing in your > > code. > > > > Could you point me to the code you mean? > > > > Sascha > > > > I only know the porting VDLL code in nxpwifi. Yes, and I asked for a pointer to that code, some function name, or file/line or whatever, because I looked at the nxpwifi driver and don't know what you mean with "VDLL data patch support" in sdio.c. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |