Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x

Sascha Hauer
2024-09-03T07:52:16Z

On Tue, Sep 03, 2024 at 07:35:59AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Tuesday, September 3, 2024 3:30 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: Francesco Dolcini <francesco@dolcini.it>; Calvin Owens
> > <calvin@wbinvd.org>; Brian Norris <briannorris@chromium.org>; Kalle Valo
> > <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de
> > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x
> >
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> >
> >
> > On Tue, Sep 03, 2024 at 06:39:15AM +0000, David Lin wrote:
> > > > > > > Not only this code segment. In fact, you did not add VDLL data
> > > > > > > patch support
> > > > > > to sdio.c.
> > > > > > > If you try to add the code and do test, you will know what is
> > > > > > > missing in your
> > > > > > code.
> > > > > >
> > > > > > Could you point me to the code you mean?
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > >
> > > > > I only know the porting VDLL code in nxpwifi.
> > > >
> > > > Yes, and I asked for a pointer to that code, some function name, or
> > > > file/line or whatever, because I looked at the nxpwifi driver and
> > > > don't know what you mean with "VDLL data patch support" in sdio.c.
> > > >
> > > > Sascha
> > > >
> > >
> > > It is better for you to check MXM driver. It is the same as Mwifiex which
> > support all SDIO modes.
> >
> > Now I am confused. You said:
> >
> > > In fact, you did not add VDLL data patch support to sdio.c
> >
> > I was under the assumption that the nxpwifi driver that you specifically posted
> > for the iw61x chipset should contain this code. Isn't that the case?
> >
> > BTW did you really mean "VDLL data patch" or did you mean "VDLL data
> > path"?
> >
>
> Sorry VDLL data path.
> You did not add the code to support this new SDIO data type in your patch.
>
> Please check MXM driver which supports all SDIO modes.

But why? The nxpwifi driver is much closer to the mwifiex driver and
much better readable, so I would rather pick the missing pieces from
there.

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |