Re: [PATCH 2/2] driver core: class: warn if a compatibility class is registered

Wolfram Sang
2024-09-03T09:06:46Z

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

On Tue, Sep 03, 2024 at 11:04:44AM +0200, Wolfram Sang wrote:
>
> > > + pr_warn("Compatibility class %s will go away soon, please migrate userspace tools to use bus devices\n",
> > > + name);
> >
> > That's not going to do anything except annoy users who have no control
> > over this, sorry. Please just fix up all of the kernel and then delete
> > this function.
>
> So, we deprecated this sysfs-class 15 years ago and hid it with a
> Kconfig symbol. However, we never pursued this further, so e.g. Debian
> has the Kconfig symbol still enabled. Can we really remove this from one
> release to the next without another transition period? I am not afraid
> of tools like lm-sensors which were converted long ago. But custom code
> might rely on sysfs-paths created by this class. It was even advertised
> in IPMI docs until last week (fixed now).

I missed that Heiner was changing the driver core, not I2C core. So, to
give more details, I am talking about I2C_COMPAT and the "i2c-adapter"
class. The main question from above still stands.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]