From: Johan Hovold <johan@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] usb: typec: Add support for Parade PS8830 Type-C Retimer
Date: Wed, 4 Sep 2024 15:20:55 +0200 [thread overview]
Message-ID: <Zthet0QqChgGWJAe@hovoldconsulting.com> (raw)
In-Reply-To: <Zta6cBq881Ju7r7H@hovoldconsulting.com>
On Tue, Sep 03, 2024 at 09:27:45AM +0200, Johan Hovold wrote:
> On Thu, Aug 29, 2024 at 09:44:26PM +0300, Abel Vesa wrote:
> > The Parade PS8830 is a Type-C muti-protocol retimer controlled over I2C.
> > It provides both altmode and orientation handling.
> >
> > Add a driver with support for the following modes:
> > - DP 4lanes
> > - USB3
> > - DP 2lanes + USB3
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > + retimer->supplies[0].supply = "vdd33";
> > + retimer->supplies[1].supply = "vdd18";
> > + retimer->supplies[2].supply = "vdd15";
>
> vdd115?
>
> > + retimer->supplies[3].supply = "vcc";
I took a look at the schematics and it seems like all but one of the
above supply names are wrong and that some are missing. "vcc" also does
not exist in either the binding or dt patches you sent separately.
From what I can tell the supplies are:
vdd 1.15 V
vdd33 3.3 V
vdd33_cap 3.3 V
vddat 1.15 V
vddar 1.15 V
vddio 1.8 V
Also, have you checked that there are no ordering constraints between
the supplies?
Johan
next prev parent reply other threads:[~2024-09-04 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 18:44 [PATCH RFC 0/2] usb: typec: Add new driver for Parade PS8830 Type-C Retimer Abel Vesa
2024-08-29 18:44 ` [PATCH RFC 1/2] dt-bindings: usb: Add Parade PS8830 Type-C retimer bindings Abel Vesa
2024-08-31 6:37 ` Krzysztof Kozlowski
2024-09-03 7:13 ` Johan Hovold
2024-08-29 18:44 ` [PATCH RFC 2/2] usb: typec: Add support for Parade PS8830 Type-C Retimer Abel Vesa
2024-08-29 19:17 ` Konrad Dybcio
2024-09-03 7:27 ` Johan Hovold
2024-09-04 13:20 ` Johan Hovold [this message]
2024-09-23 15:40 ` Abel Vesa
2024-09-23 16:03 ` Dmitry Baryshkov
2024-09-24 7:26 ` Abel Vesa
2024-08-30 0:57 ` [PATCH RFC 0/2] usb: typec: Add new driver " Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zthet0QqChgGWJAe@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox