Re: [PATCH] x86/platform/geode: switch GPIO buttons and LEDs to software properties

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Sep 04, 2024 at 06:01:30PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/4/24 3:21 PM, Borislav Petkov wrote:
> > On Wed, Sep 04, 2024 at 03:02:17PM +0200, Hans de Goede wrote:
> >> Or I can merge it through platform-drivers-x86.git/for-next
> >> with an ack from one of the x86 maintainers.
> > 
> > Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
> 
> 
> Thank you.
> 
> I've applied this patch to my review-hans branch now:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
> 
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.

Hans, could you squash the following bit into the original patch please:


diff --git a/arch/x86/platform/geode/geode-common.c b/arch/x86/platform/geode/geode-common.c
index 8f365388cfbb..d35aaf3e76a0 100644
--- a/arch/x86/platform/geode/geode-common.c
+++ b/arch/x86/platform/geode/geode-common.c
@@ -14,7 +14,7 @@
 
 #include "geode-common.h"
 
-const struct software_node geode_gpiochip_node = {
+static const struct software_node geode_gpiochip_node = {
 	.name = "cs5535-gpio",
 };
 

-- 
Dmitry