From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E8F6144D1F for ; Wed, 4 Sep 2024 19:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; cv=none; b=fvgaGRunIbcIgqUQSrr49mwrHRm7xSwhmWYnwgNSELW8I22uwvwSJbDrgLpodWgjcqk0D7v9Fc6uqAYKnMTS4SkJgZiGb88y5wx2IAmcsvgOpHq3Ry59Bviii2EA88jqSB4PYVfTbPZw+5jH1NN/veVgVJWTDb6CYABZRPvCk5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; c=relaxed/simple; bh=hLtrV9fo2ENFsppI3EM5//2a1v6xLdR6UciGmLp3E0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAjn+6z914rrce6MLO3Xq+T91w5t54fccLBHV/Y5CAD/A9KBTQAe2vnZoYb695i1PSfFF4Rdvh3MoBUsqRU5skF+Hz9ueb2FIk9GQVFn+HgDqB4lxAd+t+5Urj/245FUqNurrc0HxWPRTth71EBoonpIlVsQ1h0WNgZnTidXlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=O83/Gbf8; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="O83/Gbf8" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2d8a4bad409so3098233a91.0 for ; Wed, 04 Sep 2024 12:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1725476837; x=1726081637; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=O83/Gbf8QHytDjtKBC2VP1NHGE69K97QzsnnPLhood4y27NcYWvbRpAYJZHt9lWN5L piIbJArzYN5Qf7SPBI49vUE2VjW4GYvYSSeWevifsRIo2JwxWESaOWjUw9KNQUlcAOjW M57C0o6ln8DywnEEETUAFokbAoSyohPtRCDiZcplIwBMyuz2tior5wk9DBWcDqSCynVu jAvaHC4YqJY0ofPBytPoIllLrn/HiP7br0fsxdsL6Iq9qfvJZ6jQmTfrZAaTKNkj8iqz t2z+vruq/jHHUU7ujoGLdO82BtEDxwSzFDLuOmaaNt8DQwT2aKkt8z2EJBcsRPlrEHcB kXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725476837; x=1726081637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=hCitRmZJNgyGYKiBSNmw/JwnraiZ2K4U0d5lpmgn+YrjobMZATbjl78po2hMqbcHQh HtR4PiaRejyykiaZPqrXFAD4T8h7IHtaBm3Yql6It/1uGt90oEG4HPq9lVIJnZm0Mtg/ CeAZzV0CpXlw1yg9HIBcGQ1bm0EdD0qegL6pfwzIHol5/NeuGJKVcEVyN8Gpvd9NF6ic mfWIgYSguVoITYuhlbbHLZke0zFdE42R7Cq21sO0FS0ICv7SF+DhTrsunf+FnxnZRSte fn+lVKfc2FqDO/4YQFSXJ0ADICIw5VNZq5t/pfRfBUrrBaZfjd3JkgbkUbb0ys6Az66r a9Cw== X-Forwarded-Encrypted: i=1; AJvYcCXC73J4aVbsrKCSB5CIGZtPgy/9tUBz0xh2YTKbyqng+mY9nLJEKMIP7B2kbAijUUQ7aT1f/3gpThX8Mvg=@vger.kernel.org X-Gm-Message-State: AOJu0YxHnDuSMKvapi2332KJgen6WINtiIYrGp1TMJVdCSsi8zM9BqGG XACMgMqZdlvsgXz9KPeNncVoLKeQizRcLrtkTdIfG5LyF40pE6SbpDlGGGEvlkg= X-Google-Smtp-Source: AGHT+IGRXMFw8eODDeHuSZGixob1QmbWy894YR3dac/q8kTYt2afjYPzXJiDq5qdDnRm4AHLgT4d4Q== X-Received: by 2002:a17:90b:300e:b0:2d8:27c3:87d7 with SMTP id 98e67ed59e1d1-2d893284ebdmr13545892a91.8.1725476836620; Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da53740084sm4858056a91.32.2024.09.04.12.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Date: Wed, 4 Sep 2024 12:07:12 -0700 From: Deepak Gupta To: Mark Brown Cc: "Liam R. Howlett" , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Rick Edgecombe Subject: Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area Message-ID: References: <20240902-mm-generic-shadow-stack-guard-v1-0-9acda38b3dd3@kernel.org> <20240902-mm-generic-shadow-stack-guard-v1-3-9acda38b3dd3@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Tue, Sep 03, 2024 at 08:57:20PM +0100, Mark Brown wrote: >On Tue, Sep 03, 2024 at 03:41:49PM -0400, Liam R. Howlett wrote: >> * Mark Brown [240902 15:09]: > >> > +static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) >> > +{ >> > + if (vm_flags & VM_SHADOW_STACK) >> > + return PAGE_SIZE; > >> Is PAGE_SIZE is enough? > >It's what x86 currently uses so it'll be no worse off if it gets moved >to the generic code (there's a comment in the arch code explaing what's >needed there) and it's enough for arm64, we only do single record >pushes/pops or (optionally) writes to unconstrained addresses. It's enough for RISC-V too.