Re: [PATCH v6 0/7] Event parsing fixes

James Clark
2024-09-10T09:27:09Z

On 9/5/24 19:20, Liang, Kan wrote:
>
>
> On 2024-09-03 6:19 a.m., James Clark wrote:
>> I rebased this one and made some other fixes so that I could test it,
>> so I thought I'd repost it here in case it's helpful. I also added a
>> new test.
>>
>> But for the testing it all looks ok.
>>
>> There is one small difference where it now hides _all_ default
>> <not supported> events, when previously it would only hide some
>> selected subset of events like "stalled-cycles-frontend". I think
>> this is now more consistent across platforms because, for example,
>> Apple M only has cycles and instructions, and the rest of the
>> default events would always show as <not supported> there.
>>
>> Tested on Raptor Lake, Kaby Lake, Juno, N1, Ampere (with the DSU
>> cycles PMU) and I also faked an Apple M on Juno.
>>
>
> The tui mode in perf report is broken on Intel hybrid machine.
>
> $perf record -e cycles,instructions sleep 1
> $perf report
>
> Without the patch set, in the tui mode,
> Available samples
> 7 cpu_atom/cycles/
> ◆
> 0 cpu_core/cycles/
> ▒
> 7 cpu_atom/instructions/
> ▒
> 0 cpu_core/instructions/
> ▒
> 0 dummy:u
>
> After applying the patch set,
> Available samples
> 7 /cycles/
> ◆
> 0 /cycles/
> ▒
> 7 /instructions/
> ▒
> 0 /instructions/
> ▒
> 0 dummy:u
>
>
> It looks something wrong with the uniquify_event_name().
>
> Thanks,
> Kan
>

Thanks, taking a look.