From: Mike Snitzer <snitzer@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: agk@redhat.com, mpatocka@redhat.com, dm-devel@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: dm integrity: Convert comma to semicolon
Date: Thu, 5 Sep 2024 10:34:55 -0400 [thread overview]
Message-ID: <ZtnBjyn8eSygoaT1@kernel.org> (raw)
In-Reply-To: <20240905022832.1642756-1-nichen@iscas.ac.cn>
On Thu, Sep 05, 2024 at 10:28:32AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
I agree, the use of comma is bizarre. Not sure how that slipped
through but...
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
next prev parent reply other threads:[~2024-09-05 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 2:28 [PATCH] dm integrity: Convert comma to semicolon Chen Ni
2024-09-05 14:34 ` Mike Snitzer [this message]
2024-09-06 11:38 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtnBjyn8eSygoaT1@kernel.org \
--to=snitzer@kernel.org \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox