Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s

[Johan Hovold <johan@kernel.org>]

On Thu, Sep 05, 2024 at 11:04:37PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Sep 05, 2024 at 06:27:36PM +0200, Johan Hovold wrote:
> > On Thu, Sep 05, 2024 at 08:57:42PM +0530, Manivannan Sadhasivam wrote:
 
> > > Perhaps we can just get rid of the Kconfig entry and build it by default for
> > > both RC and EP drivers? I don't see a value in building it as a separate module.
> > > And we may also move more common code in the future.
> > 
> > It is already built by default for both drivers. I'm not sure what
> > you're suggesting here.
> 
> Right now it is selected by both drivers using a Kconfig symbol. But I'm
> thinking of building it by default as below:
> 
> -obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o
> -obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o
> +obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o pcie-qcom-common.o
> +obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o pcie-qcom-common.o
> 
> A separate Kconfig symbol is not really needed here as this file contains common
> code required by both the drivers.

But the separate Kconfig symbol will only be enabled via either PCI
driver's option (e.g. can't be enabled on its own).

I'm also not sure if the above works if you build one driver as a module
and the other into the kernel (yes, I still intend to resubmit my patch
for making the rc driver modular).

Johan