From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Tyrone Ting <warp5tw@gmail.com>,
avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, wsa@kernel.org, rand.sec96@gmail.com,
wsa+renesas@sang-engineering.com, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com,
openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] i2c: npcm: restore slave addresses array length
Date: Fri, 6 Sep 2024 14:40:53 +0300 [thread overview]
Message-ID: <ZtrqRc5XYmYBtonw@smile.fi.intel.com> (raw)
In-Reply-To: <xdaufg4bju3iq5fqeo2gdej3yaxyufhuaiuyixnla234l2ej3r@fmvann767tib>
On Thu, Sep 05, 2024 at 11:36:45PM +0200, Andi Shyti wrote:
> On Fri, Aug 30, 2024 at 11:46:34AM GMT, Tyrone Ting wrote:
> > The smatch check warning is "buffer overflow 'npcm_i2caddr' 2 <= 9".
> > The original design supports 10 slave addresses although only 2
> > addresses are required for current implementation.
> >
> > Restore the npcm_i2caddr array length to fix the smatch warning.
> >
> > Fixes: 47d506d1a28f ("i2c: npcm: Remove own slave addresses 2:10")
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Closes: https://lore.kernel.org/r/202408130818.FgDP5uNm-lkp@intel.com/
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
>
> your email used in From: is different that your e-mail used the
> SoB. Is this done in purpose? If so I will keep it as it is, no
> problem for me, otherwise I can fix it while applying it.
IIRC Linux Next has the respective check and it will become your problem :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-06 11:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 3:46 [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 1/7] i2c: npcm: restore slave addresses array length Tyrone Ting
2024-09-05 21:23 ` Andi Shyti
2024-09-06 2:23 ` Tyrone Ting
2024-09-05 21:36 ` Andi Shyti
2024-09-06 2:28 ` Tyrone Ting
2024-09-06 6:49 ` Andi Shyti
2024-09-06 11:40 ` Andy Shevchenko [this message]
2024-09-06 7:05 ` Andi Shyti
2024-09-06 8:01 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 2/7] i2c: npcm: correct the read/write operation procedure Tyrone Ting
2024-09-05 21:29 ` Andi Shyti
2024-09-08 10:39 ` Tali Perry
2024-09-09 1:49 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 3/7] i2c: npcm: use a software flag to indicate a BER condition Tyrone Ting
2024-09-05 21:33 ` Andi Shyti
2024-08-30 3:46 ` [PATCH v2 4/7] i2c: npcm: Modify timeout evaluation mechanism Tyrone Ting
2024-09-05 21:39 ` Andi Shyti
2024-09-08 10:47 ` Tali Perry
2024-09-09 1:47 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 5/7] i2c: npcm: Modify the client address assignment Tyrone Ting
2024-08-30 19:16 ` Andy Shevchenko
2024-09-02 1:40 ` Tyrone Ting
2024-09-02 11:54 ` Andy Shevchenko
2024-09-03 2:07 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 6/7] i2c: npcm: use i2c frequency table Tyrone Ting
2024-08-30 19:19 ` Andy Shevchenko
2024-09-01 15:53 ` Tali Perry
2024-09-02 11:53 ` Andy Shevchenko
2024-09-08 8:54 ` Tali Perry
2024-09-09 10:27 ` Andy Shevchenko
2024-09-05 21:43 ` Andi Shyti
2024-09-09 1:56 ` Tyrone Ting
2024-09-09 12:57 ` Andi Shyti
2024-09-10 1:11 ` Tyrone Ting
2024-08-30 3:46 ` [PATCH v2 7/7] i2c: npcm: Enable slave in eob interrupt Tyrone Ting
2024-09-08 10:50 ` Tali Perry
2024-09-08 10:58 ` [PATCH v2 0/7] i2c: npcm: Bug fixes read/write operation, checkpatch Tali Perry
2024-09-09 13:00 ` Andi Shyti
2024-09-10 1:12 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtrqRc5XYmYBtonw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andi.shyti@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=kfting@nuvoton.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rand.sec96@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=warp5tw@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox