Re: [PATCH v2] mm: add lazyfree folio to lru tail

Suren Baghdasaryan
2024-08-19T16:12:05Z

On Fri, Aug 16, 2024 at 3:21 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 16.08.24 12:19, David Hildenbrand wrote:
> > On 16.08.24 09:48, gaoxu wrote:
> >> Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree_fn:
> >> 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's
> >> moved to the LRU tail, it allows for faster release lazy-free folio and
> >> reduces the impact on file refault.
> >> 2. When mglru is enabled, the lazy-free folio is reclaimabled and should be
> >> added using lru_gen_add_folio(lruvec, folio, true) instead of
> >> lru_gen_add_folio(lruvec, folio, false) for adding to gen.
> >>
> >> With the change in place, workingset_refault_file is reduced by 33% in the
> >> continuous startup testing of the applications in the Android system.

Was this improvement recorded with MGLRU enabled or disabled?
CC'ing Yu Zhao as well.

> >>
> >
> > The patch subject does not match what you do in the patch -- at all.
> >
> > "mm/swap: use lruvec_add_folio_tail() in lru_lazyfree()" ?
>
> Ah, sorry, I read it too fast. Yours does make sense :)
>
> (mm/swap might make sense, though)
>
> --
> Cheers,
>
> David / dhildenb
>