Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on different channel

Sascha Hauer
2024-09-10T07:21:58Z

On Tue, Sep 10, 2024 at 06:18:57AM +0000, David Lin wrote:
> > > > > > With DRCS support enabled AP and STA actually can run on
> > > > > > different channels with the current code. You are breaking this
> > > > > > scenario with this
> > > > patch.
> > > > > >
> > > > > > Sascha
> > > > > >
> > > > >
> > > > > DRCS will be checked in the future.
> > > >
> > > > By future you mean v3 of this patch?
> > > >
> > > > Sascha
> > > >
> > >
> > > No schedule now.
> >
> > I am getting confused now. You want us to abandon my patch in favour of yours,
> > but you have no plans to update your patch to avoid a regression that you
> > introduce with your patch?
> >
> > Sascha
> >
>
> My patch resolves the same issue as your patch. But your patch can't
> let AP and STA run on the same channel if some wiphy parameters are
> set.
>
> I wonder did you test your patch?

I finally see what you mean with "some wiphy parameters are set".
I did test my patch and I didn't run into this issue, because I haven't
set anything like rts_threshold in my config.

Nevertheless what I am trying to tell you in this thread is: Your patch
introduces a regression and needs an update.

It's not about my patch or your patch, both are currently not suitable
for inclusion and the question is: will you update your patch?

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |