Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on different channel

Sascha Hauer
2024-09-09T20:33:28Z

On Mon, Sep 02, 2024 at 10:35:01AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Monday, September 2, 2024 5:38 PM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> > briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Pete
> > Hsieh <tsung-hsien.hsieh@nxp.com>
> > Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
> > different channel
> >
> > On Mon, Sep 02, 2024 at 04:43:11PM +0800, David Lin wrote:
> > > Current firmware doesn't support AP and STA running on different
> > > channels simultaneously.
> >
> > As mentioned here:
> >
> > https://lore.kern/
> > el.org%2Fall%2FZtGnWC7SPHt7Vbbp%40pengutronix.de%2F&data=05%7C02%
> > 7Cyu-hao.lin%40nxp.com%7Cce9b7d4e417c41113c7d08dccb32fc49%7C686ea
> > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638608667089710854%7CUnkn
> > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> > aWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=nMZO565xCUO%2BwxD4tIfi
> > w6cGyYrinaEsi7XLfqyxgXg%3D&reserved=0
> >
> > AP and STA can indeed have different channels when DRCS is enabled, so I
> > think you have to check this in your patch.
> >
> > Maybe the same question here again: Wouldn't it make sense to enable DRCS
> > by default?
> >
> > Sascha
> >
>
> I will look into DRCS support later after current tasks on hand.
> This patch is a quick fix to avoid firmware crash in the specific scenario.

With DRCS support enabled AP and STA actually can run on different
channels with the current code. You are breaking this scenario with this
patch.

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |