From: Baoquan He <bhe@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, dyoung@redhat.com,
daniel.kiper@oracle.com, noodles@fb.com, lijiang@redhat.com,
kexec@lists.infradead.org
Subject: Re: [PATCH v2 2/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y
Date: Tue, 10 Sep 2024 17:40:37 +0800 [thread overview]
Message-ID: <ZuAUFTgK5G2xzSya@MiWiFi-R3L-srv> (raw)
In-Reply-To: <43291018-098f-291a-629b-6e02ef00f8e5@amd.com>
On 09/09/24 at 09:53am, Tom Lendacky wrote:
> On 8/29/24 05:40, Baoquan He wrote:
......snip..
> > Here fix the code bug to make kexec/kdump kernel boot up successfully.
> >
> > And also fix the similar buggy code in memremap_is_setup_data() which
> > are found out during code reviewing.
>
> I think you should add something along the lines that the "len" variable
> in struct setup_data is the length of the "data" field and does not
> include the size of the struct, which is the reason for the miscalculation.
Fair enough. I will send v3 to add the reason of miscalculation.
>
> Otherwise:
>
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Thanks a lot for careful checking.
prev parent reply other threads:[~2024-09-10 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 10:40 [PATCH v2 0/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y Baoquan He
2024-08-29 10:40 ` [PATCH v2 1/2] x86/mm: rename the confusing local variable in early_memremap_is_setup_data() Baoquan He
2024-09-09 14:43 ` Tom Lendacky
2024-08-29 10:40 ` [PATCH v2 2/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y Baoquan He
2024-09-09 14:53 ` Tom Lendacky
2024-09-10 9:40 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuAUFTgK5G2xzSya@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@fb.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox