From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: kprobes: Massage previous delay slot detection
Date: Tue, 10 Sep 2024 12:50:58 +0200 [thread overview]
Message-ID: <ZuAkknRoKraAJkFC@alpha.franken.de> (raw)
In-Reply-To: <b4833f82-9e7e-4667-994b-c444ef935a9f@app.fastmail.com>
On Tue, Sep 10, 2024 at 10:43:23AM +0100, Jiaxun Yang wrote:
>
>
> 在2024年9月9日九月 下午11:02，Maciej W. Rozycki写道：
> > On Sun, 8 Sep 2024, Jiaxun Yang wrote:
> >
> >> Expand the if condition into cascaded ifs to make code
> >> readable.
> >
> > Apart from broken formatting what's making original code unreadable?
>
> For me it's confusing because wired layout, cascaded ifs are clearly
> easier to format and has clear intention.
I prefer the original version, it's just to statements combined with &&,
which isn't scary at all.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2024-09-10 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 10:49 [PATCH 0/2] MIPS: Chore clean ups Jiaxun Yang
2024-09-08 10:49 ` [PATCH 1/2] MIPS: ftrace: Mark ftrace_get_parent_ra_addr as static Jiaxun Yang
2024-09-09 21:59 ` Maciej W. Rozycki
2024-09-08 10:49 ` [PATCH 2/2] MIPS: kprobes: Massage previous delay slot detection Jiaxun Yang
2024-09-09 22:02 ` Maciej W. Rozycki
2024-09-10 9:43 ` Jiaxun Yang
2024-09-10 10:50 ` Thomas Bogendoerfer [this message]
2024-09-10 21:03 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuAkknRoKraAJkFC@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox