From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13904188CB1; Tue, 10 Sep 2024 11:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725966970; cv=none; b=mq4hMe/dQXqP2tl01VZk9HcO2+WfrZKcSw1aAaPMz9r3pDq5BX6u9ecKMF64R+T8gu4D6dlbOu1oAsF88tYBwxQ//MrNTJBsf4w8dpPotPC/pjSUQunMolnMwKdKrXHBhuvEYiYAeR96gRXjvOQUOeYC7sfXaT/oeC7on60GONo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725966970; c=relaxed/simple; bh=WwuWzlfalxUbA7n9dc2q0GE+bRK2RGMy6unlIrwup+E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=trJoqdhNHECjvw5mcQsywn4/3vXpRFbchXhFVwYfNb0/KwVDzWmd0aN6b8DySkx++Wolc89o+PHtRfP7RRLqBEktMCTR2YiQcf9ZhZIyOOQ1h2OV3PrDRbSTeAavbiElludO9WZdwpvAT2+Q4M5RGXYfgONzMO0uuIQTxmJe3yo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1snyqf-0004WW-00; Tue, 10 Sep 2024 13:15:53 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3819BC014D; Tue, 10 Sep 2024 12:50:58 +0200 (CEST) Date: Tue, 10 Sep 2024 12:50:58 +0200 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: "Maciej W. Rozycki" , "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: kprobes: Massage previous delay slot detection Message-ID: References: <20240908-mips-chore-v1-0-9239c783f233@flygoat.com> <20240908-mips-chore-v1-2-9239c783f233@flygoat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Sep 10, 2024 at 10:43:23AM +0100, Jiaxun Yang wrote: > > > 在2024年9月9日九月 下午11:02，Maciej W. Rozycki写道： > > On Sun, 8 Sep 2024, Jiaxun Yang wrote: > > > >> Expand the if condition into cascaded ifs to make code > >> readable. > > > > Apart from broken formatting what's making original code unreadable? > > For me it's confusing because wired layout, cascaded ifs are clearly > easier to format and has clear intention. I prefer the original version, it's just to statements combined with &&, which isn't scary at all. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]