From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67F2195FEF for ; Tue, 10 Sep 2024 17:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725990561; cv=none; b=LZ6k2j36rruL61DNpJ7yu2o8IMNMoQv3BO3ky/vtXprGxl/cwQYE63MdLRbpiTwuvH9apMOtUU2/5DoNs3xi+CIEoP7BC7qCrw9efTIw7MFy46DQ0hlD0jmkqqYQVFM3QYkn8Oj3WindKqImTWlVwKINlhWYH6DH7t5z/69BNU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725990561; c=relaxed/simple; bh=qD0RMhJC1X69Bc1xPhY+pcb8oykGLcMvvnLcohOLFbo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=t7kv1lV5kqq4rL64jPfew1RVcG6+vAK/xzMfPNj1hOCBLzxaYoxyUgX8FV+37a1DWKIQW+cFJXEbdD0WtaHw1yIj5T/O6Z5eu3WMjg0122HCNDHWpKkQtYWzGsQHbWPEem+nlzuSAN/w1dVWN2MjcHwT8icTU4xirX8DIwl6VOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WKigZ8HA; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WKigZ8HA" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-7c6a4d99dbdso611642a12.0 for ; Tue, 10 Sep 2024 10:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725990559; x=1726595359; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5GCtRoN4l/HV1t3VyVnIOd2i48Y7q41rosWH07pYdbA=; b=WKigZ8HA1IoP95uiI++0Wdafq+zMuWaW5BFqbgFJMJjCJ3y3JNaUbdBI6FKR+9TpDK 3u+uKhZO+2XgIpuPqtH1Ysqb1Ojv9GVAV6IRBHkSi00kVZvOdo/WpoDTJf0OPhfmBlcd nGhKeULNXE0JA+S/599JXJ8P/5qBC5QqpiMtVB+c/NTe1BHHzE2N5N1yBFzzt/+DGQ7T +HctoNh8mQwy9NcxsPTILV22u9ZQ5Jn/dATnMDtNq1/BorRASjDqh34LojAFMjmjJ3nY xeBndjY5j/BU+GIww3eSe5nN/JRfIObD0vnuFWz8Wtjpt0vXbGONLFrlhhF1EbPIvaha 0ndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725990559; x=1726595359; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GCtRoN4l/HV1t3VyVnIOd2i48Y7q41rosWH07pYdbA=; b=Ypdm5o7hf0orqgPPOAbNrp2a6dAj/bmsaBzfn1rZryYYYaO26vd2gTey+cjLxuqy5h y1H0Oaq1uKW/wRqVxkYyv5hWdOAwpyGxe9VJD6U0lKDRINzX4WH/jwOZEJe3ksEOXZFR XFuCiZJ7gkeSUjtBtkEFEfjx6DorFIypPI0g2t/GOjGA0wd8C1QhJXjIaLhgrmLP3mm+ f4IKXZcmsHu2PU5P59jvsGI7xdX6c04aYXm4bGv6EnOHRy9v/W7fRDYHDe7jYRt3a07f /YhREW24YgEB93SQBWCy6/oZb7thvTY/ewycEcv15Fr4lhruDP+51PAseb4PfAPowY2w r4Pg== X-Forwarded-Encrypted: i=1; AJvYcCXM/l2aQVn3/l7K1WMcPIMsqCy9wE/DeRxc82FGmg53stndEncnTMtDlvm49y4ZN1EY4UMUvOlmhGosQ80=@vger.kernel.org X-Gm-Message-State: AOJu0YySL/+BtLajvlQ0R59+vpnsY0CdsR2eXxx3AGOts148YtFHCYC4 mshazP5ugzGdHDcwvmo+grpm/xVvlN6CMYw6cQT0fQMec2actEpigp+Q6+zJ5TLeSJ2d/hjE2vd vcA== X-Google-Smtp-Source: AGHT+IE0bC55Fj5C1M7tUMI/uFlWyflj/zZjItUmPtulbZEQ/c7Awy4AZcEA/dOkmwlRR9wGz+mi9ExaqV8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a65:668a:0:b0:7d8:449f:1491 with SMTP id 41be03b00d2f7-7db083b8b78mr13737a12.0.1725990558945; Tue, 10 Sep 2024 10:49:18 -0700 (PDT) Date: Tue, 10 Sep 2024 10:49:17 -0700 In-Reply-To: <0b8577af-222f-4195-8d75-d8cc5fcf6cda@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240812224820.34826-1-rick.p.edgecombe@intel.com> <20240812224820.34826-3-rick.p.edgecombe@intel.com> <4eb4a26e-ebad-478e-9635-93f7fbed103b@intel.com> <4de6d1fa5f72274af51d063dc17726625de535ac.camel@intel.com> <0b8577af-222f-4195-8d75-d8cc5fcf6cda@redhat.com> Message-ID: Subject: Re: [PATCH 02/25] KVM: TDX: Define TDX architectural definitions From: Sean Christopherson To: Paolo Bonzini Cc: Rick P Edgecombe , Xiaoyao Li , "kvm@vger.kernel.org" , Isaku Yamahata , "sean.j.christopherson@intel.com" , "tony.lindgren@linux.intel.com" , Kai Huang , "isaku.yamahata@gmail.com" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" On Tue, Sep 10, 2024, Paolo Bonzini wrote: > On 8/29/24 21:46, Edgecombe, Rick P wrote: > > > This leads to another topic that defining all the TDX structure in this > > > patch seems unfriendly for review. It seems better to put the > > > introduction of definition and its user in a single patch. > > > > Yea. > > I don't know, it's easier to check a single patch against the manual. I > don't have any objection to leaving everything here instead of scattering it > over multiple patches, in fact I think I prefer it. +1. There is so much to understand with TDX that trying to provide some form of temporal locality between architectural definitions and the first code to use a given definition seems futile/pointless.