From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084B2167DB7 for ; Tue, 10 Sep 2024 18:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725992332; cv=none; b=OD5vWaF4rrvZP1z0JiLNc0OZ21JsL4OrNyirOshxAffu/DKOCHrgAqB0STibKrxxh9lk4CZ83dfd82gnyyBLCGB+KLSkbX2ekxZc6+AYqLqpAlmj9ZmsMgSysfy9h2BDieyzmwU0x0o0tPFhLKOwCpW7TiMf2DWPgEoecbsvBaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725992332; c=relaxed/simple; bh=cX8E7Kd7KJjcUM/fS5ucxgvF6aBOoZSTP6rRvIrRuvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=orkiuTDYWljVjsAQAWXoqUXISEreYKkSq1J9FrI7+M94tqjPw87lMl0PJbAHaCOgpSAh48Iv65dcHNmxBSMMtTEv/T5U0HukPxBCXxJFehR7BknZHVZoSvTun/ti3iQ97DxrbdUvR/46Vyeb1F3/TlnKq1E4/l8InUSm49jaahU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eMBNfTv8; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eMBNfTv8" Date: Tue, 10 Sep 2024 18:18:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725992327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpLtxrldAJA6kgdh8lUC/02V3THaPKjHYDTFam1Jz4g=; b=eMBNfTv8PX2paFmyRCbblRB9zsv/mmCbzE2Fpg7oXKcoAvgF0kEr5/rtrEq5Tw9ARFOpX/ NfHgL2yakpaA63qSOBtnU7DMECvFPmaE/ReI2KldPTPxwFN42Mbr9hLaELfAAsJ+X3HZRi xbN8pKnfxwfNtEgmgbdN62+vVZo0Hcc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Wei-Lin Chang Cc: Snehal Koukuntla , Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Sudeep Holla , Sebastian Ene , Vincent Donnefort , Jean-Philippe Brucker , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] KVM: arm64: Add memory length checks and remove inline in do_ffa_mem_xfer Message-ID: References: <20240909180154.3267939-1-snehalreddy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, Sep 11, 2024 at 12:32:29AM +0800, Wei-Lin Chang wrote: > Hi everyone, > > On Mon, Sep 09, 2024 at 06:01:54PM GMT, Snehal Koukuntla wrote: > > When we share memory through FF-A and the description of the buffers > > exceeds the size of the mapped buffer, the fragmentation API is used. > > The fragmentation API allows specifying chunks of descriptors in subsequent > > FF-A fragment calls and no upper limit has been established for this. > > The entire memory region transferred is identified by a handle which can be > > used to reclaim the transferred memory. > > To be able to reclaim the memory, the description of the buffers has to fit > > in the ffa_desc_buf. > > Add a bounds check on the FF-A sharing path to prevent the memory reclaim > > from failing. > > > > Also do_ffa_mem_xfer() does not need __always_inline > > > > Fixes: 634d90cf0ac65 ("KVM: arm64: Handle FFA_MEM_LEND calls from the host") > > Cc: stable@vger.kernel.org > > Reviewed-by: Sebastian Ene > > Signed-off-by: Snehal Koukuntla > > --- > > arch/arm64/kvm/hyp/nvhe/ffa.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > > index e715c157c2c4..637425f63fd1 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > > @@ -426,7 +426,7 @@ static void do_ffa_mem_frag_tx(struct arm_smccc_res *res, > > return; > > } > > > > -static __always_inline void do_ffa_mem_xfer(const u64 func_id, > > +static void do_ffa_mem_xfer(const u64 func_id, > > I am seeing a compilation error because of this. Thanks for reporting this. Looks like the __always_inline was slightly more load bearing... Marc, can you put something like this on top? >From c2712eaa94989ae6457baad3ec459cf363ec5119 Mon Sep 17 00:00:00 2001 From: Oliver Upton Date: Tue, 10 Sep 2024 16:45:30 +0000 Subject: [PATCH] KVM: arm64: Drop BUILD_BUG_ON() from do_ffa_mem_xfer() __always_inline was recently discarded from do_ffa_mem_xfer() since it appeared to be unnecessary. Of course, this was ~immediately proven wrong, as the compile-time check against @func_id depends on inlining for the value to be known. Just downgrade to a WARN_ON() instead of putting the old mess back in place. Fix the wrapping/indentation of the function parameters while at it. Fixes: 39dacbeeee70 ("KVM: arm64: Add memory length checks and remove inline in do_ffa_mem_xfer") Reported-by: Wei-Lin Chang Signed-off-by: Oliver Upton --- arch/arm64/kvm/hyp/nvhe/ffa.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c index 637425f63fd1..316d269341f3 100644 --- a/arch/arm64/kvm/hyp/nvhe/ffa.c +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c @@ -426,9 +426,8 @@ static void do_ffa_mem_frag_tx(struct arm_smccc_res *res, return; } -static void do_ffa_mem_xfer(const u64 func_id, - struct arm_smccc_res *res, - struct kvm_cpu_context *ctxt) +static void do_ffa_mem_xfer(const u64 func_id, struct arm_smccc_res *res, + struct kvm_cpu_context *ctxt) { DECLARE_REG(u32, len, ctxt, 1); DECLARE_REG(u32, fraglen, ctxt, 2); @@ -440,8 +439,10 @@ static void do_ffa_mem_xfer(const u64 func_id, u32 offset, nr_ranges; int ret = 0; - BUILD_BUG_ON(func_id != FFA_FN64_MEM_SHARE && - func_id != FFA_FN64_MEM_LEND); + if (WARN_ON(func_id != FFA_FN64_MEM_SHARE && func_id != FFA_FN64_MEM_LEND)) { + ret = SMCCC_RET_NOT_SUPPORTED; + goto out; + } if (addr_mbz || npages_mbz || fraglen > len || fraglen > KVM_FFA_MBOX_NR_PAGES * PAGE_SIZE) { -- 2.46.0.598.g6f2099f65c-goog -- Thanks, Oliver