Re: [PATCH v9 4/7] remoteproc: core: Add TEE interface support for firmware release

Arnaud POULIQUEN
2024-09-02T07:20:50Z

On 8/31/24 18:43, kernel test robot wrote:
> Hi Arnaud,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on 5be63fc19fcaa4c236b307420483578a56986a37]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Arnaud-Pouliquen/remoteproc-core-Introduce-rproc_pa_to_va-helper/20240830-175609
> base: 5be63fc19fcaa4c236b307420483578a56986a37
> patch link: https://lore.kernel.org/r/20240830095147.3538047-5-arnaud.pouliquen%40foss.st.com
> patch subject: [PATCH v9 4/7] remoteproc: core: Add TEE interface support for firmware release
> config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240901/202409010034.Tln3soEY-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/202409010034.Tln3soEY-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409010034.Tln3soEY-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers/remoteproc/remoteproc_core.c:32:
>>> include/linux/remoteproc_tee.h:52:12: warning: 'tee_rproc_parse_fw' defined but not used [-Wunused-function]
> 52 | static int tee_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
> | ^~~~~~~~~~~~~~~~~~
>
>
> vim +/tee_rproc_parse_fw +52 include/linux/remoteproc_tee.h
>
> 498143a453d14e Arnaud Pouliquen 2024-08-30 51
> 498143a453d14e Arnaud Pouliquen 2024-08-30 @52 static int tee_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
> 498143a453d14e Arnaud Pouliquen 2024-08-30 53 {
> 498143a453d14e Arnaud Pouliquen 2024-08-30 54 /* This shouldn't be possible */
> 498143a453d14e Arnaud Pouliquen 2024-08-30 55 WARN_ON(1);
> 498143a453d14e Arnaud Pouliquen 2024-08-30 56
> 498143a453d14e Arnaud Pouliquen 2024-08-30 57 return 0;
> 498143a453d14e Arnaud Pouliquen 2024-08-30 58 }
> 498143a453d14e Arnaud Pouliquen 2024-08-30 59
>

The inline attribute is missing. As it is a minor fix, I'm waiting for more
reviews before fixing it in the next version.

Regards,
Arnaud