From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Shuah Khan <shuah@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Jens Remus <jremus@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: vDSO: fix vdso_config for s390
Date: Wed, 11 Sep 2024 15:42:52 +0200 [thread overview]
Message-ID: <ZuGeXMeRPoeuqz66@zx2c4.com> (raw)
In-Reply-To: <20240911085015.3581722-3-hca@linux.ibm.com>
On Wed, Sep 11, 2024 at 10:50:15AM +0200, Heiko Carstens wrote:
> Running vdso_test_correctness on s390x (aka s390 64 bit) emits a warning:
>
> Warning: failed to find clock_gettime64 in vDSO
>
> This is caused by the "#elif defined (__s390__)" check in vdso_config.h
> which the defines VDSO_32BIT.
>
> If __s390x__ is defined also __s390__ is defined. Therefore the correct
> check must make sure that only __s390__ is defined.
>
> Therefore add the missing !defined(__s390x__). Also use common
> __s390x__ define instead of __s390X__.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
I'll add to it:
Fixes: 693f5ca08ca0 ("kselftest: Extend vDSO selftest")
next prev parent reply other threads:[~2024-09-11 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 8:50 [PATCH 0/2] selftests: vDSO: s390 fixes Heiko Carstens
2024-09-11 8:50 ` [PATCH 1/2] selftests: vDSO: fix ELF hash table entry size for s390x Heiko Carstens
2024-09-11 8:50 ` [PATCH 2/2] selftests: vDSO: fix vdso_config for s390 Heiko Carstens
2024-09-11 13:42 ` Jason A. Donenfeld [this message]
2024-09-11 13:40 ` [PATCH 0/2] selftests: vDSO: s390 fixes Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuGeXMeRPoeuqz66@zx2c4.com \
--to=jason@zx2c4.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox