[PATCH] kernel/workqueue.c: fix DEFINE_PER_CPU_SHARED_ALIGNED expansion

[PATCH] kernel/workqueue.c: fix DEFINE_PER_CPU_SHARED_ALIGNED expansion

[Baoquan He]

Make tags always produces below annoying warnings:

ctags: Warning: kernel/workqueue.c:470: null expansion of name pattern "\1"
ctags: Warning: kernel/workqueue.c:474: null expansion of name pattern "\1"
ctags: Warning: kernel/workqueue.c:478: null expansion of name pattern "\1"

In commit 25528213fe9f ("tags: Fix DEFINE_PER_CPU expansions"), codes in
places have been adjusted including cpu_worker_pools definition. I noticed
in commit 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually
replace tasklets"), cpu_worker_pools definition was unfolded back. Not
sure if it was intentionally done or ignored carelessly.

Makes change to mute them specifically. 

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 - If this is not expected, please ignore it.

 kernel/workqueue.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e7b005ff3750..10ea9d1e65ad 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -476,16 +476,13 @@ static bool wq_debug_force_rr_cpu = false;
 module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, 0644);
 
 /* to raise softirq for the BH worker pools on other CPUs */
-static DEFINE_PER_CPU_SHARED_ALIGNED(struct irq_work [NR_STD_WORKER_POOLS],
-				     bh_pool_irq_works);
+static DEFINE_PER_CPU_SHARED_ALIGNED(struct irq_work [NR_STD_WORKER_POOLS], bh_pool_irq_works);
 
 /* the BH worker pools */
-static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
-				     bh_worker_pools);
+static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], bh_worker_pools);
 
 /* the per-cpu worker pools */
-static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
-				     cpu_worker_pools);
+static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], cpu_worker_pools);
 
 static DEFINE_IDR(worker_pool_idr);	/* PR: idr of all pools */
 
-- 
2.41.0

Re: [PATCH] kernel/workqueue.c: fix DEFINE_PER_CPU_SHARED_ALIGNED expansion

[Tejun Heo]

On Wed, Sep 11, 2024 at 01:07:28PM +0800, Baoquan He wrote:
> Make tags always produces below annoying warnings:
> 
> ctags: Warning: kernel/workqueue.c:470: null expansion of name pattern "\1"
> ctags: Warning: kernel/workqueue.c:474: null expansion of name pattern "\1"
> ctags: Warning: kernel/workqueue.c:478: null expansion of name pattern "\1"
> 
> In commit 25528213fe9f ("tags: Fix DEFINE_PER_CPU expansions"), codes in
> places have been adjusted including cpu_worker_pools definition. I noticed
> in commit 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually
> replace tasklets"), cpu_worker_pools definition was unfolded back. Not
> sure if it was intentionally done or ignored carelessly.
> 
> Makes change to mute them specifically. 
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>

Applied to wq/for-6.12.

Thanks.

-- 
tejun