public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "John B. Wyatt IV" <jwyatt@redhat.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Min-Hua Chen <minhuadotchen@gmail.com>,
	Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
	John Kacur <jkacur@redhat.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i
Date: Thu, 12 Sep 2024 13:36:40 -0400	[thread overview]
Message-ID: <ZuMmqAmr62ErjqHc@rhfedora> (raw)
In-Reply-To: <5785527a-b259-42ba-989e-978d2e72ff35@linuxfoundation.org>

On Thu, Sep 12, 2024 at 10:31:19AM -0600, Shuah Khan wrote:
> On 9/12/24 06:50, Min-Hua Chen wrote:
> > This RFC patch is actually bug report. All *.i file will be
> > removed by 'make mrproper', including raw_pylibcpupower.i, added
> > by commit: 338f490e07bc ("pm:cpupower: Add SWIG bindings files for libcpupower")
> > 
> > We can reproduce the error by performing the following command:
> > cd linux-next
> > make mrproper
> > cd tools/power/cpupower/bindings/python
> > make
> > 
> > We will get an error message:
> > make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'.  Stop.
> > 
> > Renaming the raw_pylibcpupower.i is just a workaround to fix the
> > issue above.
> 
> I need a non-rfc patch for this. Please send a proper patch
> I can pull in once John has a chance to review this.

I have reviewed and tested and this. I am good with it being a stopgap.

Please send the non-rfc patch.

Thank you for reporting and sending a patch for this Min-Hua.

Reviewed-by: John B. Wyatt IV <jwyatt@redhat.com>
Reviewed-by: John B. Wyatt IV <sageofredondo@gmail.com>
Tested-by: John B. Wyatt IV <jwyatt@redhat.com>
Tested-by: John B. Wyatt IV <sageofredondo@gmail.com>

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat


  reply	other threads:[~2024-09-12 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 12:50 [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i Min-Hua Chen
2024-09-12 16:31 ` Shuah Khan
2024-09-12 17:36   ` John B. Wyatt IV [this message]
2024-09-12 20:03     ` Shuah Khan
2024-09-12 22:55       ` Min-Hua Chen
2024-09-13 16:35         ` John B. Wyatt IV
2024-09-13 16:45           ` Shuah Khan
2024-09-12 22:49     ` Min-Hua Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuMmqAmr62ErjqHc@rhfedora \
    --to=jwyatt@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=minhuadotchen@gmail.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox