From: Charlie Jenkins <charlie@rivosinc.com>
To: WangYuli <wangyuli@uniontech.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, samuel.holland@sifive.com,
conor.dooley@microchip.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, atish.patra@wdc.com,
anup@brainfault.org, guanwentao@uniontech.com,
zhanjun@uniontech.com
Subject: Re: [RESEND. PATCH] riscv: Use '%u' to format the output of 'cpu'
Date: Thu, 12 Sep 2024 13:37:54 -0700 [thread overview]
Message-ID: <ZuNRIrfLgkWUsZri@ghost> (raw)
In-Reply-To: <E4CA32D7942C8637+20240912134946.163833-1-wangyuli@uniontech.com>
On Thu, Sep 12, 2024 at 09:49:46PM +0800, WangYuli wrote:
> 'cpu' is an unsigned integer, so its placeholder should be %u, not %d.
>
> Suggested-by: Wentao Guan <guanwentao@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> arch/riscv/kernel/cpu-hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/cpu-hotplug.c b/arch/riscv/kernel/cpu-hotplug.c
> index 28b58fc5ad19..a1e38ecfc8be 100644
> --- a/arch/riscv/kernel/cpu-hotplug.c
> +++ b/arch/riscv/kernel/cpu-hotplug.c
> @@ -58,7 +58,7 @@ void arch_cpuhp_cleanup_dead_cpu(unsigned int cpu)
> if (cpu_ops->cpu_is_stopped)
> ret = cpu_ops->cpu_is_stopped(cpu);
> if (ret)
> - pr_warn("CPU%d may not have stopped: %d\n", cpu, ret);
> + pr_warn("CPU%u may not have stopped: %d\n", cpu, ret);
> }
>
> /*
> --
> 2.43.4
Thanks!
Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
Tested-by: Charlie Jenkins <charlie@rivosinc.com>
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-09-12 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 13:49 [RESEND. PATCH] riscv: Use '%u' to format the output of 'cpu' WangYuli
2024-09-12 20:37 ` Charlie Jenkins [this message]
2024-09-13 3:11 ` WangYuli
2024-09-12 22:12 ` Maciej W. Rozycki
2024-09-13 2:51 ` WangYuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuNRIrfLgkWUsZri@ghost \
--to=charlie@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox