From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A627340C03 for ; Fri, 13 Sep 2024 02:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726195887; cv=none; b=PI1Y6rfmf07dOrwGIUzJ7MqDGTmtFcAxKrbp+W0/flbU5Fx+Xt4t3wM3w+9G1Qj3FpVMyayYkwBqgudhM7EaZgBUTfFTbddb4A7tCk3GtDy1qHhZoaxuUNwEhZm+MvNdNJnULZBBi73ENzKdnk+ivPoUtvZKAcW0QftLuRMYwi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726195887; c=relaxed/simple; bh=AN4DtVKMFJj+Oka4ewoJjhlxUHL0Ou2WbvKruw5A9Vg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XO8eZTvV87kw23fUcnoyiBIItayri6BDS8qayX9BY5p27RfLf4m5tZgSuLX1pnA8o7/HWf9iTss4AcxGoYTaTFOXlC0lWTEIOpOzsSqJqs2+RnJmeoZyCL5haDS0wWTp3AelNkwHFpcmg/A4TDP+phN25xATuYo3BDfnU5BWMKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=ZLl1fNrt; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="ZLl1fNrt" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7191901abd6so346692b3a.3 for ; Thu, 12 Sep 2024 19:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1726195884; x=1726800684; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7lucKHZRD1F8sNhQoF0GbULdmAnhRsrGT0LLKCZjQ8Q=; b=ZLl1fNrtCqmkdQ382N7VDZy2JOd14XjwPAbzHzgvUi+CeVt+f8zlsbo4Mp/pZvRGH8 ns0tU92Jl+wKIBTMfPFbAeJGeZW3Ajv0HsBBazurcwNBkcgnuRFCV1hAj/S+8pL5bv8+ DAiQD6+dPe/6DNJnJVRnd3I1+mySPREtjbUjBFzQlwMB8oHzPbGGnIBRpBiA0+u38j9b TIbXar+jbPPolb3OvP/mp2ushsDtnVB3vUARfha2mOSPJ6aHlNqMi960NUMvNKVh5tUp svQMjN2RpD5obnFzEb5UIf7veRBgJu8htMrnhJPF4pIly2Do6pAVOtdtcoGAEYhQ0HxS 5udw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726195884; x=1726800684; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7lucKHZRD1F8sNhQoF0GbULdmAnhRsrGT0LLKCZjQ8Q=; b=VB43Ujg4nrPE25NkvZ8ea7KLrKMMhXg1zO12E5R3QfgXVxt0LnYVN3lKXg5ZVsvF+f CDkVpqHARk7WFf/Nl7Q74rlp2xfsyZwVIEhDpA2soMYHTSzr4CcQYLgDDRxHroCTRTW6 lpU4u8rPWcIwEWM6fQq9FpJ+euSZ+bG9A/n8J0ex54UUl048WP77cl/QcKjXcACiO3br PUiZqS6ch390/NKSe4m6SC+nC8UPa6Pk/DQLuYpcC23jBnqLX/iskVmEv4PgqVns8Dul 8dRcOQsLISDvxHkd0q8AcKOp3j4riUsUYwcspAp7byyoKlbScwoirliSnPibGS5+WZCM 2LuA== X-Forwarded-Encrypted: i=1; AJvYcCXVghIc/KS1NJXZ1S2bgseGnGlzghyK2pKhJO6GrXN8ENuHV8vpe24abN8fqSW2cLWTw0tskmnwpmxrmhI=@vger.kernel.org X-Gm-Message-State: AOJu0YyvVV884+gCaVAouwgzTyu+MMgXAQUjeZ4zc1sh/k72pZWngv1T bBhIL287KwTLc//UA40y2W4F8xBaUa9OH50she1bsM2e7wfXCsb6NIKnba4k794= X-Google-Smtp-Source: AGHT+IF0SPnqCcWggj+ZbMP5BdP/rIV8aCEiZw6gABT7Jq6B8FmEO+5IPUNs4ZDtOMOgvUeBHKH7Nw== X-Received: by 2002:a05:6300:668a:b0:1cc:cdb6:c116 with SMTP id adf61e73a8af0-1d112db1368mr1881160637.24.1726195883833; Thu, 12 Sep 2024 19:51:23 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71908fc8febsm5398290b3a.19.2024.09.12.19.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 19:51:23 -0700 (PDT) Date: Thu, 12 Sep 2024 19:51:21 -0700 From: Charlie Jenkins To: Samuel Holland Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Anup Patel , Conor Dooley , kasan-dev@googlegroups.com, Atish Patra , Evgenii Stepanov , Krzysztof Kozlowski , Rob Herring , "Kirill A . Shutemov" Subject: Re: [PATCH v4 06/10] riscv: Allow ptrace control of the tagged address ABI Message-ID: References: <20240829010151.2813377-1-samuel.holland@sifive.com> <20240829010151.2813377-7-samuel.holland@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829010151.2813377-7-samuel.holland@sifive.com> On Wed, Aug 28, 2024 at 06:01:28PM -0700, Samuel Holland wrote: > This allows a tracer to control the ABI of the tracee, as on arm64. > > Signed-off-by: Samuel Holland > --- Since this code is identical to the arm64 port, could it be extracted out into the generic ptrace.c and ifdef on either CONFIG_RISCV_ISA_SUPM or CONFIG_ARM64_TAGGED_ADDR_ABI by adding some generic flag like CONFIG_HAVE_ARCH_TAGGED_ADDR_ABI? - Charlie > > (no changes since v1) > > arch/riscv/kernel/ptrace.c | 42 ++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/elf.h | 1 + > 2 files changed, 43 insertions(+) > > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c > index 92731ff8c79a..ea67e9fb7a58 100644 > --- a/arch/riscv/kernel/ptrace.c > +++ b/arch/riscv/kernel/ptrace.c > @@ -28,6 +28,9 @@ enum riscv_regset { > #ifdef CONFIG_RISCV_ISA_V > REGSET_V, > #endif > +#ifdef CONFIG_RISCV_ISA_SUPM > + REGSET_TAGGED_ADDR_CTRL, > +#endif > }; > > static int riscv_gpr_get(struct task_struct *target, > @@ -152,6 +155,35 @@ static int riscv_vr_set(struct task_struct *target, > } > #endif > > +#ifdef CONFIG_RISCV_ISA_SUPM > +static int tagged_addr_ctrl_get(struct task_struct *target, > + const struct user_regset *regset, > + struct membuf to) > +{ > + long ctrl = get_tagged_addr_ctrl(target); > + > + if (IS_ERR_VALUE(ctrl)) > + return ctrl; > + > + return membuf_write(&to, &ctrl, sizeof(ctrl)); > +} > + > +static int tagged_addr_ctrl_set(struct task_struct *target, > + const struct user_regset *regset, > + unsigned int pos, unsigned int count, > + const void *kbuf, const void __user *ubuf) > +{ > + int ret; > + long ctrl; > + > + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &ctrl, 0, -1); > + if (ret) > + return ret; > + > + return set_tagged_addr_ctrl(target, ctrl); > +} > +#endif > + > static const struct user_regset riscv_user_regset[] = { > [REGSET_X] = { > .core_note_type = NT_PRSTATUS, > @@ -182,6 +214,16 @@ static const struct user_regset riscv_user_regset[] = { > .set = riscv_vr_set, > }, > #endif > +#ifdef CONFIG_RISCV_ISA_SUPM > + [REGSET_TAGGED_ADDR_CTRL] = { > + .core_note_type = NT_RISCV_TAGGED_ADDR_CTRL, > + .n = 1, > + .size = sizeof(long), > + .align = sizeof(long), > + .regset_get = tagged_addr_ctrl_get, > + .set = tagged_addr_ctrl_set, > + }, > +#endif > }; > > static const struct user_regset_view riscv_user_native_view = { > diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h > index b54b313bcf07..9a32532d7264 100644 > --- a/include/uapi/linux/elf.h > +++ b/include/uapi/linux/elf.h > @@ -448,6 +448,7 @@ typedef struct elf64_shdr { > #define NT_MIPS_MSA 0x802 /* MIPS SIMD registers */ > #define NT_RISCV_CSR 0x900 /* RISC-V Control and Status Registers */ > #define NT_RISCV_VECTOR 0x901 /* RISC-V vector registers */ > +#define NT_RISCV_TAGGED_ADDR_CTRL 0x902 /* RISC-V tagged address control (prctl()) */ > #define NT_LOONGARCH_CPUCFG 0xa00 /* LoongArch CPU config registers */ > #define NT_LOONGARCH_CSR 0xa01 /* LoongArch control and status registers */ > #define NT_LOONGARCH_LSX 0xa02 /* LoongArch Loongson SIMD Extension registers */ > -- > 2.45.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv