From: Sudeep Holla <sudeep.holla@arm.com>
To: "Miquel Sabaté Solà" <mikisabate@gmail.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, cuiyunhui@bytedance.com,
jeremy.linton@arm.com, sunilvl@ventanamicro.com,
linux-riscv@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Prevent a bad reference count on CPU nodes
Date: Fri, 13 Sep 2024 10:07:05 +0100 [thread overview]
Message-ID: <ZuQAufXBEp-87mrv@bogus> (raw)
In-Reply-To: <20240913080053.36636-1-mikisabate@gmail.com>
On Fri, Sep 13, 2024 at 10:00:52AM +0200, Miquel Sabaté Solà wrote:
> When populating cache leaves we previously fetched the CPU device node
> at the very beginning. But when ACPI is enabled we go through a
> specific branch which returns early and does not call 'of_node_put' for
> the node that was acquired.
>
> Since we are not using a CPU device node for the ACPI code anyways, we
> can simply move the initialization of it just passed the ACPI block, and
> we are guaranteed to have an 'of_node_put' call for the acquired node.
> This prevents a bad reference count of the CPU device node.
>
> Moreover, the previous function did not check for errors when acquiring
> the device node, so a return -ENOENT has been added for that case.
>
LGTM,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
> ---
> I was wondering if this should also be sent to stable, but I have not seen
> a report on it, and this is not responsible for an oops or anything like that.
> So in the end I decided not to, but maybe you consider otherwise.
>
Right, it is not a fix per say and hence not a stable material as ACPI
is not accessing the node pointer.
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-09-13 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 8:00 [PATCH] riscv: Prevent a bad reference count on CPU nodes Miquel Sabaté Solà
2024-09-13 9:07 ` Sudeep Holla [this message]
2024-09-18 2:19 ` [External] " yunhui cui
2024-09-30 12:35 ` Miquel Sabaté Solà
2024-10-08 13:38 ` Miquel Sabaté Solà
2024-10-10 12:29 ` Alexandre Ghiti
2024-10-10 14:32 ` Miquel Sabaté Solà
2024-09-30 16:28 ` Sunil V L
2024-10-17 16:30 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuQAufXBEp-87mrv@bogus \
--to=sudeep.holla@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=cuiyunhui@bytedance.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mikisabate@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sunilvl@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox