Re: [PATCH 3/6] libstub,tpm: provide indication of failure when getting event log

Gregory Price
2024-09-13T23:07:33Z

On Fri, Sep 13, 2024 at 04:10:08PM +0300, Ilias Apalodimas wrote:
> On Fri, 13 Sept 2024 at 15:58, Gregory Price <gourry@gourry.net> wrote:
> >
> > > > - if (status != EFI_SUCCESS || !log_location)
> > > > + if (status != EFI_SUCCESS || !log_location) {
> > > > + efi_err("TPM unable to provide Event Log\n");
> > >
> > > s/provide/retrieve/ and yes the print is going to be useful. Do you
> > > know if the EventLog is mandatory. Reading at the spec GetEventlog
> > > only has 2 return values, which implies you can't return "Not
> > > supported", but it's not explicitly stated anywhere
> > >
> >
> > I believe it is mandatory from my reading of the spec - but the
> > "Final Event Log" was only added in 2.0. We report an error when
> > 2.0 is reported but the final event log is not supported, so i figure
> > we should probably report when the event log fails as well.
>
> Yea I am fine with that, I was just wondering if we should do _err or
> _warn. I am fine with the error
>
> /Ilias

Per Ard's notes on patch 6 i'm going to drop this. These prints apparently
don't actually end up anywhere.

~Gregory